From: Saul Wold <sgw@linux.intel.com>
To: Andrei Gherzan <andrei@gherzan.ro>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] util-linux: Fix bloken swapoff symlink
Date: Wed, 19 Sep 2012 10:35:47 -0700 [thread overview]
Message-ID: <505A0273.3050705@linux.intel.com> (raw)
In-Reply-To: <1347878998-19019-1-git-send-email-andrei@gherzan.ro>
On 09/17/2012 03:49 AM, Andrei Gherzan wrote:
> There were 2 issues with this symlink.
> 1. Is was installed in base_bindidir but packaged in bindir. Fixed to
> be packaged in base_bindir
> 2. The symlink swapoff was created to point to swapon. The problem is
> that swapoff is an alternative so it would end up pointing to
> swapoff.util-linux which was an inexistent file. The fix is to create
> a symlink swapoff.util-linux to swapon.util-linux.
>
> Signed-off-by: Andrei Gherzan <andrei@gherzan.ro>
> ---
> meta/recipes-core/util-linux/util-linux.inc | 4 ++--
> meta/recipes-core/util-linux/util-linux_2.21.2.bb | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-core/util-linux/util-linux.inc b/meta/recipes-core/util-linux/util-linux.inc
> index 00e5d7c..79e0608 100644
> --- a/meta/recipes-core/util-linux/util-linux.inc
> +++ b/meta/recipes-core/util-linux/util-linux.inc
> @@ -46,7 +46,7 @@ FILES_util-linux-agetty = "${base_sbindir}/agetty"
> FILES_util-linux-fdisk = "${base_sbindir}/fdisk.${BPN}"
> FILES_util-linux-cfdisk = "${base_sbindir}/cfdisk"
> FILES_util-linux-sfdisk = "${sbindir}/sfdisk"
> -FILES_util-linux-swaponoff = "${base_sbindir}/swapon.${BPN} ${sbindir}/swapoff.${BPN}"
> +FILES_util-linux-swaponoff = "${base_sbindir}/swapon.${BPN} ${base_sbindir}/swapoff.${BPN}"
> FILES_util-linux-losetup = "${base_sbindir}/losetup.${BPN}"
> FILES_util-linux-mount = "${base_bindir}/mount.${BPN}"
> FILES_util-linux-mcookie = "${bindir}/mcookie"
> @@ -121,7 +121,7 @@ do_install () {
> install -d ${D}${sysconfdir}/default/
> echo 'MOUNTALL="-t nonfs,nosmbfs,noncpfs"' > ${D}${sysconfdir}/default/mountall
>
> - ln -sf swapon ${D}${base_sbindir}/swapoff
> + ln -sf swapon.${BPN} ${D}${base_sbindir}/swapoff.${BPN}
> rm -f ${D}${sbindir}/swapoff
> }
>
> diff --git a/meta/recipes-core/util-linux/util-linux_2.21.2.bb b/meta/recipes-core/util-linux/util-linux_2.21.2.bb
> index 0f5fdc6..6ef3163 100644
> --- a/meta/recipes-core/util-linux/util-linux_2.21.2.bb
> +++ b/meta/recipes-core/util-linux/util-linux_2.21.2.bb
> @@ -1,5 +1,5 @@
> MAJOR_VERSION = "2.21"
> -PR = "r1"
> +PR = "r2"
> require util-linux.inc
>
> # note that `lscpu' is under GPLv3+
>
Merged into OE-Core
Thanks
Sau!
prev parent reply other threads:[~2012-09-19 17:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 10:49 [PATCH] util-linux: Fix bloken swapoff symlink Andrei Gherzan
2012-09-19 17:35 ` Saul Wold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505A0273.3050705@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=andrei@gherzan.ro \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox