Re: [RFC PATCH] eglibc: Move perl- and bash-using scripts to separate recipes

From: Saul Wold <sgw@linux.intel.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: Phil Blundell <philb@gnu.org>,
	oe-core <openembedded-core@lists.openembedded.org>
Subject: Re: [RFC PATCH] eglibc: Move perl- and bash-using scripts to separate recipes
Date: Sun, 23 Sep 2012 21:40:02 -0700	[thread overview]
Message-ID: <505FE422.3090809@linux.intel.com> (raw)
In-Reply-To: <CAMKF1sp3_DKmhCw3jrxuKFNf_a6iP_+6EyytXDg1d-zc+Ei22A@mail.gmail.com>

On 09/23/2012 07:11 PM, Khem Raj wrote:
> On Sun, Sep 23, 2012 at 2:17 PM, Phil Blundell <philb@gnu.org> wrote:
>> This removes the dependency of eglibc.bb itself on perl and bash
>> which, in turn, eliminates the need to build those two recipes if the
>> scripts which need them are not going to be installed.
>>
>
> I think this is a good patch.
>
This causes issues with world build and will likely also cause toolchain 
build failures since eglibc-utils is included in a couple of 
packagegroups (self-hosted and core-lsb), it's also listed in the 
tclibc-eglibc.inc LIBC_DEPENDENCIES.

I am not sure this is a candidate for 1.3 at this point either since we 
are starting the RC2 this week, so it might get held up from master, I 
know this is the RFC, so when the real patch comes.

Sau!

>> Signed-off-by: Phil Blundell <pb@pbcl.net>
>
> ...
>
>
>> --- /dev/null
>> +++ b/meta/recipes-core/eglibc/eglibc-scripts.inc
>> @@ -0,0 +1,17 @@
>> +include eglibc-collateral.inc
>> +
>> +SUMMARY = "utility scripts provided by eglibc"
>> +DESCRIPTION = "utility scripts provided by eglibc"
>> +RDEPENDS_${PN} = "bash"
>> +RDEPENDS_ldd = "bash"
>
> we do not ask for bash see
> sed -e "s#@BASH@#/bin/sh#" -i ${S}/elf/ldd.bash.in in eglibc.inc
>
>
>> +
>> +SRC = "${STAGING_INCDIR}/eglibc-scripts-internal-${MULTIMACH_TARGET_SYS}"
>> +
>> +bashscripts = "mtrace sotruss xtrace"
>> +
>> +do_install() {
>> +       install -d -m 0755 ${D}${bindir}
>> +       for i in ${bashscripts}; do
>> +               install -m 0755 ${SRC}/$i ${D}${bindir}/
>> +       done
>> +}
>> diff --git a/meta/recipes-core/eglibc/eglibc-scripts_2.16.bb b/meta/recipes-core/eglibc/eglibc-scripts_2.16.bb
>> new file mode 100644
>> index 0000000..3113362
>> --- /dev/null
>> +++ b/meta/recipes-core/eglibc/eglibc-scripts_2.16.bb
>> @@ -0,0 +1 @@
>> +require eglibc-scripts.inc
>> diff --git a/meta/recipes-core/eglibc/eglibc_2.16.bb b/meta/recipes-core/eglibc/eglibc_2.16.bb
>> index 72d134a..3a7ae50 100644
>> --- a/meta/recipes-core/eglibc/eglibc_2.16.bb
>> +++ b/meta/recipes-core/eglibc/eglibc_2.16.bb
>> @@ -3,7 +3,7 @@ require eglibc.inc
>>   SRCREV = "20393"
>>
>>   DEPENDS += "gperf-native kconfig-frontends-native"
>> -PR = "r10"
>> +PR = "r11"
>>   PR_append = "+svnr${SRCPV}"
>>
>>   EGLIBC_BRANCH="eglibc-2_16"
>> --
>> 1.7.9
>>
>>
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>