Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Phil Blundell <philb@gnu.org>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] eglibc: Remove bogus PACKAGES_DYNAMIC setting
Date: Thu, 27 Sep 2012 08:34:45 -0700	[thread overview]
Message-ID: <50647215.4000906@linux.intel.com> (raw)
In-Reply-To: <1348746272.32611.15.camel@phil-desktop>

On 09/27/2012 04:44 AM, Phil Blundell wrote:
> It transpires that eglibc has been setting PACKAGES_DYNAMIC = "libc6*" for
> some time.  However, this is bogus for at least two reasons:
>
> 1. Bitbake interprets PACKAGES_DYNAMIC as a regex, not a glob, so this will
> match against any package whose name starts "libc" plus zero or more sixes.
> This is particularly toxic because the nativesdk variant picks up the same
> value and will, consequently, start trying to build itself at the slightest
> excuse.
>
> 2. eglibc doesn't actually build any packages named "libc6<anything>", other
> than the ones that are named in PACKAGES anyway, so the dynamic provider
> declaration is in any case useless.
>
> Simply deleting the line is not sufficient since then we get the default
> value from bitbake.conf which causes eglibc.bb to fight with eglibc-locale.bb.
> So instead we must set it to the empty string for good results.
>
> Signed-off-by: Phil Blundell <pb@pbcl.net>
> ---
>   meta/recipes-core/eglibc/eglibc_2.16.bb |    3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/eglibc/eglibc_2.16.bb b/meta/recipes-core/eglibc/eglibc_2.16.bb
> index 3a7ae50..b37922d 100644
> --- a/meta/recipes-core/eglibc/eglibc_2.16.bb
> +++ b/meta/recipes-core/eglibc/eglibc_2.16.bb
> @@ -43,7 +43,8 @@ SRC_URI_append_virtclass-nativesdk = " file://ld-search-order.patch \
>   S = "${WORKDIR}/${EGLIBC_BRANCH}/libc"
>   B = "${WORKDIR}/build-${TARGET_SYS}"
>
> -PACKAGES_DYNAMIC = "libc6*"
> +PACKAGES_DYNAMIC = ""
> +
>   RPROVIDES_${PN}-dev = "libc6-dev virtual-libc-dev"
>   PROVIDES_${PN}-dbg = "glibc-dbg"
>
>
Merged into OE-Core

Thanks
	Sau!




      reply	other threads:[~2012-09-27 15:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-27 11:44 [PATCH] eglibc: Remove bogus PACKAGES_DYNAMIC setting Phil Blundell
2012-09-27 15:34 ` Saul Wold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50647215.4000906@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=philb@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox