From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mga01.intel.com ([192.55.52.88])
	by linuxtogo.org with esmtp (Exim 4.72)
	(envelope-from <sgw@linux.intel.com>) id 1THGOA-0000ck-AP
	for Openembedded-core@lists.openembedded.org;
	Thu, 27 Sep 2012 17:52:34 +0200
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
	by fmsmga101.fm.intel.com with ESMTP; 27 Sep 2012 08:39:41 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="4.80,496,1344236400"; d="scan'208";a="227326434"
Received: from unknown (HELO [10.255.13.173]) ([10.255.13.173])
	by fmsmga001.fm.intel.com with ESMTP; 27 Sep 2012 08:39:39 -0700
Message-ID: <5064733A.6000704@linux.intel.com>
Date: Thu, 27 Sep 2012 08:39:38 -0700
From: Saul Wold <sgw@linux.intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:15.0) Gecko/20120827 Thunderbird/15.0
MIME-Version: 1.0
To: Jason Wessel <jason.wessel@windriver.com>
References: <1348753966-45893-1-git-send-email-jason.wessel@windriver.com>
In-Reply-To: <1348753966-45893-1-git-send-email-jason.wessel@windriver.com>
Cc: Openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] cml1.bbclass: Convert tab indentation in python functions into four-space
X-BeenThere: openembedded-core@lists.openembedded.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: Patches and discussions about the oe-core layer
	<openembedded-core.lists.openembedded.org>
List-Unsubscribe: <http://lists.linuxtogo.org/cgi-bin/mailman/options/openembedded-core>,
	<mailto:openembedded-core-request@lists.openembedded.org?subject=unsubscribe>
List-Archive: <http://lists.linuxtogo.org/pipermail/openembedded-core>
List-Post: <mailto:openembedded-core@lists.openembedded.org>
List-Help: <mailto:openembedded-core-request@lists.openembedded.org?subject=help>
List-Subscribe: <http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core>,
	<mailto:openembedded-core-request@lists.openembedded.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Sep 2012 15:52:34 -0000
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

On 09/27/2012 06:52 AM, Jason Wessel wrote:
> Based on the previous commit 604d46c686d06d62d5a07b9c7f4fa170f99307d8
> (Convert tab indentation in python functions into four-space), the
> cml.bbclass was not converted, and in order to properly extend it
> with external bbappend's it needs to be converted.
>
> Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
> ---
>   meta/classes/cml1.bbclass |   28 ++++++++++++++--------------
>   1 files changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/meta/classes/cml1.bbclass b/meta/classes/cml1.bbclass
> index 37ed792..ba44196 100644
> --- a/meta/classes/cml1.bbclass
> +++ b/meta/classes/cml1.bbclass
> @@ -15,23 +15,23 @@ HOSTLDFLAGS = "${BUILD_LDFLAGS}"
>   HOST_LOADLIBES = "-lncurses"
>
>   python do_menuconfig() {
> -        try:
> -            mtime = os.path.getmtime(".config")
> -        except OSError:
> -            mtime = 0
> +    try:
> +        mtime = os.path.getmtime(".config")
> +    except OSError:
> +        mtime = 0
>
> -        oe_terminal("${SHELL} -c \"make menuconfig; if [ $? -ne 0 ]; then echo 'Command failed.'; printf 'Press any key to continue... '; read r; fi\"", '${PN} Configuration', d)
> +    oe_terminal("${SHELL} -c \"make menuconfig; if [ $? -ne 0 ]; then echo 'Command failed.'; printf 'Press any key to continue... '; read r; fi\"", '${PN} Configuration', d)
>
> -        # FIXME this check can be removed when the minimum bitbake version has been bumped
> -        if hasattr(bb.build, 'write_taint'):
> -            try:
> -                newmtime = os.path.getmtime(".config")
> -            except OSError:
> -                newmtime = 0
> +    # FIXME this check can be removed when the minimum bitbake version has been bumped
> +    if hasattr(bb.build, 'write_taint'):
> +        try:
> +            newmtime = os.path.getmtime(".config")
> +        except OSError:
> +            newmtime = 0
>
> -            if newmtime > mtime:
> -                bb.note("Configuration changed, recompile will be forced")
> -                bb.build.write_taint('do_compile', d)
> +        if newmtime > mtime:
> +            bb.note("Configuration changed, recompile will be forced")
> +            bb.build.write_taint('do_compile', d)
>   }
>   do_menuconfig[depends] += "ncurses-native:do_populate_sysroot"
>   do_menuconfig[nostamp] = "1"
>

Merged into OE-Core

Thanks
	Sau!