Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Xin Ouyang <Xin.Ouyang@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] at: atd remove useless --make-pidfile option.
Date: Thu, 27 Sep 2012 08:51:29 -0700	[thread overview]
Message-ID: <50647601.9020106@linux.intel.com> (raw)
In-Reply-To: <1348643353-32175-1-git-send-email-Xin.Ouyang@windriver.com>

On 09/26/2012 12:09 AM, Xin Ouyang wrote:
> For start-stop-daemon, --make-pidfile is used when starting a
> program that does not create its own pid file.
> atd would create its own /var/run/atd.pid, so remove this option.
>
> Signed-off-by: Xin Ouyang <Xin.Ouyang@windriver.com>
> ---
>   meta/recipes-extended/at/at_3.1.13.bb |    2 +-
>   meta/recipes-extended/at/files/S99at  |    2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-extended/at/at_3.1.13.bb b/meta/recipes-extended/at/at_3.1.13.bb
> index a391d6e..3580e09 100644
> --- a/meta/recipes-extended/at/at_3.1.13.bb
> +++ b/meta/recipes-extended/at/at_3.1.13.bb
> @@ -11,7 +11,7 @@ PAM_DEPS = "libpam libpam-runtime pam-plugin-env pam-plugin-limits"
>
>   RCONFLICTS_${PN} = "atd"
>   RREPLACES_${PN} = "atd"
> -PR = "r3"
> +PR = "r4"
>
>   SRC_URI = "${DEBIAN_MIRROR}/main/a/at/at_${PV}.orig.tar.gz \
>       file://configure.patch \
> diff --git a/meta/recipes-extended/at/files/S99at b/meta/recipes-extended/at/files/S99at
> index bcfcbda..386f8a4 100644
> --- a/meta/recipes-extended/at/files/S99at
> +++ b/meta/recipes-extended/at/files/S99at
> @@ -7,7 +7,7 @@ umask 077
>
>   start() {
>   	echo -n "Starting atd: "
> -	start-stop-daemon --start --quiet --make-pidfile --pidfile /var/run/atd.pid --background --exec /usr/sbin/atd -- -f
> +	start-stop-daemon --start --quiet --pidfile /var/run/atd.pid --background --exec /usr/sbin/atd -- -f
>   	echo "OK"
>   }
>   stop() {
>

Merged into OE-Core

Thanks
	Sau!




      reply	other threads:[~2012-09-27 16:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-26  7:09 [PATCH] at: atd remove useless --make-pidfile option Xin Ouyang
2012-09-27 15:51 ` Saul Wold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50647601.9020106@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=Xin.Ouyang@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox