From: Saul Wold <sgw@linux.intel.com>
To: Elizabeth Flanagan <elizabeth.flanagan@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/3] license.bbclass: Variable standardization
Date: Thu, 27 Sep 2012 09:55:56 -0700 [thread overview]
Message-ID: <5064851C.2020105@linux.intel.com> (raw)
In-Reply-To: <c2df57712e4e2ce9e87121b063835f51e5a76d7c.1348695851.git.elizabeth.flanagan@intel.com>
On 09/26/2012 02:50 PM, Elizabeth Flanagan wrote:
> The variable mentioned in license.conf is LICENSE_PATH. The variable
> used in license.bbclass is LICENSE_DIR. Conforming to what is in
> license.conf
>
> Signed-off-by: Elizabeth Flanagan <elizabeth.flanagan@intel.com>
> ---
> meta/classes/license.bbclass | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta/classes/license.bbclass b/meta/classes/license.bbclass
> index ffcaf93..ad543f6 100644
> --- a/meta/classes/license.bbclass
> +++ b/meta/classes/license.bbclass
> @@ -186,7 +186,7 @@ python do_populate_lic() {
> license_source_dirs = []
> license_source_dirs.append(generic_directory)
> try:
> - additional_lic_dirs = d.getVar('LICENSE_DIR', True).split()
> + additional_lic_dirs = d.getVar('LICENSE_PATH', True).split()
Beth, I found that we also have LICENSE_DIRECTORY, so the intent here is
to be a multiple directory (such as a search PATH) for licenses?
There is also some documentation that needs to be changed, should not
prevent this patch from being pulled.
Sau!
> for lic_dir in additional_lic_dirs:
> license_source_dirs.append(lic_dir)
> except:
>
next prev parent reply other threads:[~2012-09-27 17:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 21:50 [PATCH 0/3] license.bbclass fixes Elizabeth Flanagan
2012-09-26 21:50 ` [PATCH 1/3] license.bbclass: Variable standardization Elizabeth Flanagan
2012-09-27 16:55 ` Saul Wold [this message]
2012-09-26 21:50 ` [PATCH 2/3] bitbake.conf: parse license config Elizabeth Flanagan
2012-09-26 21:50 ` [PATCH 3/3] license.conf/bbclass: Move globals to license.conf Elizabeth Flanagan
2012-09-27 17:08 ` [PATCH 0/3] license.bbclass fixes Saul Wold
2012-09-27 23:50 ` Flanagan, Elizabeth
2012-09-27 23:56 ` Saul Wold
2012-09-28 10:20 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5064851C.2020105@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=elizabeth.flanagan@intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox