From: Saul Wold <sgw@linux.intel.com>
To: Bogdan Marinescu <bogdan.a.marinescu@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] Fix invalid test for network error
Date: Mon, 01 Oct 2012 14:10:08 -0700 [thread overview]
Message-ID: <506A06B0.4010401@linux.intel.com> (raw)
In-Reply-To: <1349101037-5831-1-git-send-email-bogdan.a.marinescu@intel.com>
The commit message should include the filename such as:
sanity.bbclass: Fix invalid test for network error
Sau!
On 10/01/2012 07:17 AM, Bogdan Marinescu wrote:
> The test for network error in sanity.bbclass was negated.
>
> Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com>
> ---
> meta/classes/sanity.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> index e2095dd..f2e9a74 100644
> --- a/meta/classes/sanity.bbclass
> +++ b/meta/classes/sanity.bbclass
> @@ -174,7 +174,7 @@ def check_sanity_tmpdir_change(tmpdir, data):
> # Check that we can fetch from various network transports
> errmsg = check_connectivity(data)
> testmsg = testmsg + check_connectivity(data)
> - return testmsg, errmsg == ""
> + return testmsg, errmsg != ""
>
> def check_sanity_version_change(data):
> # Sanity checks to be done when SANITY_VERSION changes
>
next prev parent reply other threads:[~2012-10-01 21:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-01 14:17 [PATCH] Fix invalid test for network error Bogdan Marinescu
2012-10-01 21:10 ` Saul Wold [this message]
2012-10-03 1:47 ` Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506A06B0.4010401@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=bogdan.a.marinescu@intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox