From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com ([143.182.124.21]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1TOrhO-0004dS-4A for openembedded-core@lists.openembedded.org; Thu, 18 Oct 2012 17:07:50 +0200 Received: from azsmga002.ch.intel.com ([10.2.17.35]) by azsmga101.ch.intel.com with ESMTP; 18 Oct 2012 07:54:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.80,608,1344236400"; d="scan'208";a="157696401" Received: from unknown (HELO envy.home) ([10.255.14.139]) by AZSMGA002.ch.intel.com with ESMTP; 18 Oct 2012 07:54:27 -0700 Message-ID: <508017E6.6060601@linux.intel.com> Date: Thu, 18 Oct 2012 10:53:26 -0400 From: Darren Hart User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121009 Thunderbird/16.0 MIME-Version: 1.0 To: Bruce Ashfield References: <7b8c12ae454f69996f935aef35cccc6d352b0964.1350571171.git.bruce.ashfield@windriver.com> In-Reply-To: <7b8c12ae454f69996f935aef35cccc6d352b0964.1350571171.git.bruce.ashfield@windriver.com> X-Enigmail-Version: 1.4.5 Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH 1/1] kernel.bbclass: remove explicit version.h target X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2012 15:07:50 -0000 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On 10/18/2012 10:47 AM, Bruce Ashfield wrote: > The compilation routine for the kernel has an explicit call to > build version.h, which works fine for most kernels, but the > location of it has recently changes. > > commit d183e6f5 [UAPI: Move linux/version.h] > commit 10b63956 [UAPI: Plumb the UAPI Kbuilds into the user > header installation and checking] > > moves the file to include/generated/linux/version.h and then to > include/generated/uapi/linux/version.h. > > As a result kernel builds of 3.7 or bisection builds of intermediate > kernel commits will fail with: > > make[2]: *** No rule to make target `include/linux/version.h'. Stop. > > Making the explicit version.h build conditional on the version, or > via a file test would fix the problem, but it introduces some complexity > to the build. > > Even without an explicit call to build version.h, it is always produced > by the kernel build, so it can simply be removed. > > Note: it isn't clear why the explicit build of version.h was originally > required, but the prep phases of the kernel have changed significantly, > so it should no longer be required. How far back have you tested with? 3.0? If it works back to 3.0, then I'd argue it's just fine. -- Darren > > [YOCTO: #3293] > > Signed-off-by: Bruce Ashfield > --- > meta/classes/kernel.bbclass | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass > index 0df8f08..2163c1f 100644 > --- a/meta/classes/kernel.bbclass > +++ b/meta/classes/kernel.bbclass > @@ -85,7 +85,6 @@ KERNEL_IMAGETYPE_FOR_MAKE = "${@(lambda s: s[:-3] if s[-3:] == ".gz" else s)(d.g > > kernel_do_compile() { > unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS MACHINE > - oe_runmake include/linux/version.h CC="${KERNEL_CC}" LD="${KERNEL_LD}" > oe_runmake ${KERNEL_IMAGETYPE_FOR_MAKE} ${KERNEL_ALT_IMAGETYPE} CC="${KERNEL_CC}" LD="${KERNEL_LD}" > if test "${KERNEL_IMAGETYPE_FOR_MAKE}.gz" = "${KERNEL_IMAGETYPE}"; then > gzip -9c < "${KERNEL_IMAGETYPE_FOR_MAKE}" > "${KERNEL_OUTPUT}" > -- Darren Hart Intel Open Source Technology Center Yocto Project - Technical Lead - Linux Kernel