Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Darren Hart <dvhart@linux.intel.com>
To: McClintock Matthew-B29882 <B29882@freescale.com>
Cc: "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] cryptodev kernel module recipe
Date: Thu, 18 Oct 2012 16:21:15 -0400	[thread overview]
Message-ID: <508064BB.8070802@linux.intel.com> (raw)
In-Reply-To: <70CC66F5C30A414DADDA6973E4CA391A7092EF@039-SN1MPN1-002.039d.mgd.msft.net>



On 10/18/2012 04:06 PM, McClintock Matthew-B29882 wrote:
> On Thu, Oct 18, 2012 at 2:59 PM, Darren Hart <dvhart@linux.intel.com> wrote:
>>
>>
>> On 10/18/2012 02:14 AM, Khem Raj wrote:
>>>
>>> On Oct 18, 2012, at 2:57 AM, Yashpal Dutta <yashpal.dutta@freescale.com> wrote:
>>>
>>>> +-install:
>>>> ++modules_install:
>>>> +    make -C $(KERNEL_DIR) SUBDIRS=`pwd` modules_install
>>>> +-   @echo "Installing cryptodev.h in /usr/include/crypto ..."
>>>> +-   @install -D crypto/cryptodev.h /usr/include/crypto/cryptodev.h
>>>> ++   @echo "Installing cryptodev.h in $(PREFIX)/usr/include/crypto ..."
>>>> ++   @install -D crypto/cryptodev.h $(PREFIX)/usr/include/crypto/cryptodev.h
>>>> +
>>>
>>> why is it installing linux headers under /usr/include shouldn't they be under usr/include/linux ?
>>
>> And shouldn't /usr/include be one of those ${*dir} variables?
> 
> That's a patch to a Makefile... not a recipe.

Duh.... hrm. I'm not sure how we deal with this typically.

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel



  reply	other threads:[~2012-10-18 20:35 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-18  9:57 [PATCH] cryptodev kernel module recipe Yashpal Dutta
2012-10-18  6:14 ` Khem Raj
     [not found]   ` <DD178F3D66989248ABAC4C14253F477F11E36C@039-SN2MPN1-021.039d.mgd.msft.net>
2012-10-18  6:35     ` Khem Raj
2012-10-18 19:59   ` Darren Hart
2012-10-18 20:06     ` McClintock Matthew-B29882
2012-10-18 20:21       ` Darren Hart [this message]
2012-10-18 13:33 ` Bruce Ashfield
2012-10-30 18:50   ` McClintock Matthew-B29882
2012-10-31 17:11     ` Bruce Ashfield
2012-10-31 19:21       ` McClintock Matthew-B29882
2012-10-18 20:16 ` Darren Hart
2012-10-18 20:33   ` McClintock Matthew-B29882
2012-10-18 20:38     ` Darren Hart
2012-10-19  1:47       ` McClintock Matthew-B29882
2012-10-19  9:43         ` Andreas Oberritter
2012-10-19 14:45           ` Khem Raj
2012-10-30 18:53   ` McClintock Matthew-B29882

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=508064BB.8070802@linux.intel.com \
    --to=dvhart@linux.intel.com \
    --cc=B29882@freescale.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox