From: Jack Mitchell <ml@communistcode.co.uk>
To: openembedded-core@lists.openembedded.org
Subject: Re: [oe][PATCH 1/3] latencytop: disable GTK and remove gtk+ dependacy
Date: Fri, 26 Oct 2012 13:37:04 +0100 [thread overview]
Message-ID: <508A83F0.7040603@communistcode.co.uk> (raw)
In-Reply-To: <508A83A4.2040303@communistcode.co.uk>
On 26/10/12 13:35, Jack Mitchell wrote:
> On 26/10/12 13:28, Paul Eggleton wrote:
>> On Friday 26 October 2012 12:54:18 Jack Mitchell wrote:
>>> From: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
>>>
>>> ---
>>>
>>> v2
>>> - Don't use -D to define with make
>>> - Rename EXTRA_OECONF_X to EXTRA_OEMAKE_X
>>>
>>> When DISTRO_FEATURES does not contain x11, disable GTK GUI and
>>> also don't add gtk+ to the DEPENDS
>>>
>>> Signed-off-by: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
>> I think because the commit message is below the first --- it won't be
>> picked up
>> when applied. This is probably where a cover letter is more appropriate.
>>
>> Cheers,
>> Paul
>>
>
> Bah! One of these days I will get it right.
>
> I think [1] should be updated for a few more use cases e.g. multiple
> patches.
>
> So you're saying I should do:
>
> git send-email -3 --no-chain-reply-to --cover-letter --to
> openembedded-core@lists.openembedded.org --subject-prefix=oe][PATCH
>
> And also remove the '---' from my commit message on patch 1?
>
[1] http://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded
--
Jack Mitchell (jack@embed.me.uk)
Embedded Systems Engineer
http://www.embed.me.uk
--
next prev parent reply other threads:[~2012-10-26 12:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 11:54 [oe][PATCH 1/3] latencytop: disable GTK and remove gtk+ dependacy Jack Mitchell
2012-10-26 11:54 ` [oe][PATCH 2/3] packagegroup-core-tools-profile: include sysprof only if x11 is distro feature Jack Mitchell
2012-10-26 11:54 ` [oe][PATCH 3/3] babeltrace: fix depends Jack Mitchell
2012-10-26 12:28 ` [oe][PATCH 1/3] latencytop: disable GTK and remove gtk+ dependacy Paul Eggleton
2012-10-26 12:35 ` Jack Mitchell
2012-10-26 12:37 ` Jack Mitchell [this message]
2012-10-26 12:49 ` Paul Eggleton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508A83F0.7040603@communistcode.co.uk \
--to=ml@communistcode.co.uk \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox