From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail1.windriver.com ([147.11.146.13]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1TVHjR-0006PP-UR for openembedded-core@lists.openembedded.org; Mon, 05 Nov 2012 09:08:30 +0100 Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail1.windriver.com (8.14.5/8.14.3) with ESMTP id qA57sk1t014673 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Sun, 4 Nov 2012 23:54:46 -0800 (PST) Received: from [128.224.163.142] (128.224.163.142) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.2.318.4; Sun, 4 Nov 2012 23:54:44 -0800 Message-ID: <509770C2.8070202@windriver.com> Date: Mon, 5 Nov 2012 15:54:42 +0800 From: Robert Yang User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 MIME-Version: 1.0 To: Laurentiu Palcu References: <1351776182-26414-1-git-send-email-laurentiu.palcu@intel.com> <50971D45.6010608@windriver.com> In-Reply-To: <50971D45.6010608@windriver.com> Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH] populate_sdk_base.bbclass: check installation machine before installing SDK X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Nov 2012 08:08:30 -0000 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit On 11/05/2012 09:58 AM, Robert Yang wrote: > > > On 11/01/2012 09:23 PM, Laurentiu Palcu wrote: >> Do not allow installer to continue if the installation machine architecture >> does not match the intended SDK machine architecture. >> >> [YOCTO: #3269] >> >> Signed-off-by: Laurentiu Palcu >> --- >> meta/classes/populate_sdk_base.bbclass | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/meta/classes/populate_sdk_base.bbclass >> b/meta/classes/populate_sdk_base.bbclass >> index a3ac757..dc715c4 100644 >> --- a/meta/classes/populate_sdk_base.bbclass >> +++ b/meta/classes/populate_sdk_base.bbclass >> @@ -118,6 +118,14 @@ fakeroot create_shar() { >> cat << "EOF" > ${SDK_DEPLOY}/${TOOLCHAIN_OUTPUTNAME}.sh >> #!/bin/bash >> >> +INST_ARCH=$(uname -m | sed -e "s/i[3-6]86/ix86/" -e "s/x86[-_]64/x86_64/") >> +SDKMACHINE=$(echo ${SDKMACHINE} | sed -e "s/i[5-6]86/ix86/") >> + > > I'm afraid this doesn't work, how does the script know the SDKMACHINE ? > The SDKMACHINE would always be null in > poky-eglibc-x86_64-i586-toolchain-gmae-1.3+snapshot-20121104.sh > This was because i didn't set the SDKMACHINE, I seldom set it when build the sdk, but it seems that we should set it since it needs include conf/machine-sdk/${SDKMACHINE}.conf Can we check whether the SDKMACHINE is null before build the SDK or use SDK_ARCH rather than the SDKMACHINE here ? Otherwise, if we don't set the SDKMACHINE, the SDK would be built, but it can't be installed, we would always get this error: Error: Installation machine not supported! // Robert > // Robert > > >> +if [ "$INST_ARCH" != "$SDKMACHINE" ]; then >> + echo "Error: Installation machine not supported!" >> + exit -1 >> +fi >> + >> DEFAULT_INSTALL_DIR="${SDKPATH}" >> COMPONENTS_LEN=$(echo ".${SDKPATH}" | sed "s/\// /g" | wc -w) >> >> > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > >