Re: [PATCH v2] initrd: add recovery feature

[Radu Moisan <radu.moisan@intel.com>]

On 11/14/2012 01:07 AM, Saul Wold wrote:
> On 11/13/2012 01:12 PM, Radu Moisan wrote:
>> Allows you to use as root a partition instead of the rootfs.img
>> for recovering an old install, and fails safe when no rootfs is
>> found, dropping the user to a shell if something goes wrong.
>>
>> Signed-off-by: Radu Moisan <radu.moisan@intel.com>
>> Signed-off-by: Alexandru Damian <alexandru.damian@intel.com>
>> ---
>>   meta/recipes-core/initrdscripts/files/init-live.sh |   44 
>> +++++++++++++++++++-
>>   1 file changed, 42 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-core/initrdscripts/files/init-live.sh 
>> b/meta/recipes-core/initrdscripts/files/init-live.sh
>> index 5682fd1..81686b9 100644
>> --- a/meta/recipes-core/initrdscripts/files/init-live.sh
>> +++ b/meta/recipes-core/initrdscripts/files/init-live.sh
>> @@ -68,13 +68,49 @@ fatal() {
>>
>>   early_setup
>>
>> +# wait for the udevd to settle
>> +echo "Waiting for udev to settle..."
>> +udevadm settle --timeout=3
>> +
> Why are you still adding in the timeout?  This still could have 
> adverse affects on some machines, just let settle do it's job.
>
> Sau!
>
Well, I didn't see any side effects. If there are side effects I'll 
remove the timeout but please point out to me some of those. Anyway, I 
thought about this more like a safety net because I've noticed "settle" 
has some history with hanging the system boot more that it should in 
some circumstances.

Radu