From: Saul Wold <sgw@linux.intel.com>
To: Koen Kooi <koen@dominion.thruhere.net>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] image classes: use PN for depends, not IMAGE_BASE_NAME
Date: Fri, 30 Nov 2012 11:06:53 -0800 [thread overview]
Message-ID: <50B903CD.6070701@linux.intel.com> (raw)
In-Reply-To: <4294A763-939F-4201-BF2A-DE11519DD740@dominion.thruhere.net>
On 11/30/2012 08:39 AM, Koen Kooi wrote:
> ping
>
Koen,
It's been in master for a few days now, we kind of fell behind on email
ACKs.
Sau!
> Op 21 nov. 2012, om 15:44 heeft Koen Kooi <koen@dominion.thruhere.net> het volgende geschreven:
>
>> Some images override IMAGE_BASE_NAME in the recipe causing targets using image-{live,vmdk} to fail.
>>
>> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
>> ---
>> meta/classes/image-live.bbclass | 2 +-
>> meta/classes/image-vmdk.bbclass | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/classes/image-live.bbclass b/meta/classes/image-live.bbclass
>> index 2f3261e..bfb59f8 100644
>> --- a/meta/classes/image-live.bbclass
>> +++ b/meta/classes/image-live.bbclass
>> @@ -10,6 +10,6 @@ LABELS_append = " ${SYSLINUX_LABELS} "
>> ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_BASENAME}-${MACHINE}.ext3"
>>
>> do_bootimg[depends] += "${INITRD_IMAGE}:do_rootfs"
>> -do_bootimg[depends] += "${IMAGE_BASENAME}:do_rootfs"
>> +do_bootimg[depends] += "${PN}:do_rootfs"
>>
>> inherit bootimg
>> diff --git a/meta/classes/image-vmdk.bbclass b/meta/classes/image-vmdk.bbclass
>> index 736d1d7..6f7df3f 100644
>> --- a/meta/classes/image-vmdk.bbclass
>> +++ b/meta/classes/image-vmdk.bbclass
>> @@ -8,7 +8,7 @@ SYSLINUX_LABELS = "boot"
>> LABELS_append = " ${SYSLINUX_LABELS} "
>>
>> # need to define the dependency and the ROOTFS for directdisk
>> -do_bootdirectdisk[depends] += "${IMAGE_BASENAME}:do_rootfs"
>> +do_bootdirectdisk[depends] += "${PN}:do_rootfs"
>> ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_BASENAME}-${MACHINE}.ext3"
>>
>> # creating VMDK relies on having a live hddimg so ensure we
>> --
>> 1.7.7.6
>>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>
prev parent reply other threads:[~2012-11-30 19:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 14:44 [PATCH] image classes: use PN for depends, not IMAGE_BASE_NAME Koen Kooi
2012-11-30 16:39 ` Koen Kooi
2012-11-30 19:06 ` Saul Wold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B903CD.6070701@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=koen@dominion.thruhere.net \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox