From: Mark Hatle <mark.hatle@windriver.com>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] python-smartpm: Fix build error
Date: Wed, 5 Dec 2012 11:54:59 -0600 [thread overview]
Message-ID: <50BF8A73.7050509@windriver.com> (raw)
In-Reply-To: <20121205174756.GE3396@jama.jama.net>
On 12/5/12 11:47 AM, Martin Jansa wrote:
> On Wed, Dec 05, 2012 at 11:42:57AM -0600, Mark Hatle wrote:
>> On 12/5/12 10:13 AM, Saul Wold wrote:
>>> datadir is normally /usr/share so we don't need to add /share to it.
>>>
>>> Signed-off-by: Saul Wold <sgw@linux.intel.com>
>>> ---
>>> meta/recipes-devtools/python/python-smartpm_1.4.1.bb | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/meta/recipes-devtools/python/python-smartpm_1.4.1.bb b/meta/recipes-devtools/python/python-smartpm_1.4.1.bb
>>> index 254318c..3617fde 100644
>>> --- a/meta/recipes-devtools/python/python-smartpm_1.4.1.bb
>>> +++ b/meta/recipes-devtools/python/python-smartpm_1.4.1.bb
>>> @@ -44,7 +44,7 @@ inherit distutils
>>>
>>> do_install_append() {
>>> # Cleanup unused item...
>>> - rmdir ${D}${datadir}/share
>>> + rmdir ${D}${datadir}
>>
>> I believe this is wrong. There are things in /usr/share that we want from smart.
>>
>> There are docs and locales and associated files...
>>
>> I believe that was there because an errant "/usr/share/share" directory was
>> generated and that caused problems.
>
> It really was in /usr/share/share and I've moved this fix to
> distutils.bbclass in
> http://git.openembedded.org/openembedded-core/commit/?id=10457e343b27e63b35e0278b00e9c25106b0cc1b
>
> So rmdir in python-smartpm should be dropped completely... I've fix for
> that too, but still testing it together with other changes, but will
> submit that pull-request today.
Ahh, I see.. So yes, the rmdir is simply not needed then and can be removed.
--Mark
> Cheers,
>
>>
>>>
>>> # We don't support the following items
>>> rm -rf ${D}${libdir}/python*/site-packages/smart/backends/slack
>>>
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
next prev parent reply other threads:[~2012-12-05 18:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-05 16:13 [PATCH] python-smartpm: Fix build error Saul Wold
2012-12-05 17:42 ` Mark Hatle
2012-12-05 17:47 ` Martin Jansa
2012-12-05 17:54 ` Mark Hatle [this message]
2012-12-05 17:57 ` Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50BF8A73.7050509@windriver.com \
--to=mark.hatle@windriver.com \
--cc=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox