Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Kang Kai <kai.kang@windriver.com>
Cc: Zhenfeng.Zhao@windriver.com, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/2] libuser: enable python support
Date: Thu, 06 Dec 2012 16:46:22 -0800	[thread overview]
Message-ID: <50C13C5E.3010300@linux.intel.com> (raw)
In-Reply-To: <4b453b852e6dbd3c91d1ffd469cdfc5480c1ec79.1354781375.git.kai.kang@windriver.com>

On 12/06/2012 12:16 AM, Kang Kai wrote:
> Compile libuser with python support.
>
> Signed-off-by: Kang Kai <kai.kang@windriver.com>
> ---
>   meta/recipes-extended/libuser/libuser_0.57.1.bb |   12 +++++++++---
>   1 files changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-extended/libuser/libuser_0.57.1.bb b/meta/recipes-extended/libuser/libuser_0.57.1.bb
> index 99b661b..3a29695 100644
> --- a/meta/recipes-extended/libuser/libuser_0.57.1.bb
> +++ b/meta/recipes-extended/libuser/libuser_0.57.1.bb
> @@ -15,10 +15,16 @@ SRC_URI = "https://fedorahosted.org/releases/l/i/libuser/libuser-${PV}.tar.xz"
>
>   SRC_URI[md5sum] = "be82c6941264d0b4bd04f95fb342ec7d"
>   SRC_URI[sha256sum] = "a61289867581fa715354a3fafe09c3e481173ce0a2dcb33b04588b6ac13cead5"
> -PR = "r2"
> +PR = "r3"
>
>   DEPENDS = "popt libpam glib-2.0 xz-native docbook-utils-native linuxdoc-tools-native"
>
> -EXTRA_OECONF += "--without-python"
> +inherit autotools gettext pythonnative python-dir
> +
> +EXTRA_OEMAKE = "PYTHON_CPPFLAGS=-I${STAGING_INCDIR}/${PYTHON_DIR}"
> +
This change seems to have a problem with the non-gplv3, possibly some 
library or newer api is needed by the python code.

Please review, you might need a wrapper with INCOMPATIBLE_LICENSE check 
for enabling or disabling the python.

Thanks
    Sau!

> +PACKAGES += "${PN}-python "
> +
> +FILES_${PN}-dbg += "${PYTHON_SITEPACKAGES_DIR}/.debug"
> +FILES_${PN}-python = "${PYTHON_SITEPACKAGES_DIR}"
>
> -inherit autotools gettext
>



  reply	other threads:[~2012-12-07  1:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-06  8:16 [PATCH 0/2] Enable python support for libnewt and libuser Kang Kai
2012-12-06  8:16 ` [PATCH 1/2] newt: enable python support Kang Kai
2012-12-06  8:16 ` [PATCH 2/2] libuser: " Kang Kai
2012-12-07  0:46   ` Saul Wold [this message]
2012-12-07  6:46     ` Kang Kai
  -- strict thread matches above, loose matches on Subject: below --
2012-12-10  9:37 [PATCH 0/2] V2: Enable python support for libnewt and libuser Kang Kai
2012-12-10  9:37 ` [PATCH 2/2] libuser: enable python support Kang Kai
2012-12-12 10:48 [PATCH 0/2] V3: Enable python support for libnewt and libuser Kang Kai
2012-12-12 10:48 ` [PATCH 2/2] libuser: enable python support Kang Kai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50C13C5E.3010300@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=Zhenfeng.Zhao@windriver.com \
    --cc=kai.kang@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox