Re: [PATCH V1] initscripts/urandom: create directory before staging into it

[Ming Liu <ming.liu@windriver.com>]

On 12/06/2012 10:22 AM, ChenQi wrote:
> On 12/06/2012 03:30 AM, Saul Wold wrote:
>> On 12/04/2012 11:57 PM, Ming Liu wrote:
>>> /etc/init.d/urandom fails to start/stop because it tries to save
>>> random-seed into /var/lib/urandom folder which does not exist in the
>>> file system.
>>>
>>> Fixed by creating /var/lib/urandom at do_install time.
>>>
>>> Signed-off-by: Ming Liu <ming.liu@windriver.com>
>>> ---
>>>   meta/recipes-core/initscripts/initscripts_1.0.bb | 4 +++-
>>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/meta/recipes-core/initscripts/initscripts_1.0.bb 
>>> b/meta/recipes-core/initscripts/initscripts_1.0.bb
>>> index d25838b..39be9a8 100644
>>> --- a/meta/recipes-core/initscripts/initscripts_1.0.bb
>>> +++ b/meta/recipes-core/initscripts/initscripts_1.0.bb
>>> @@ -3,7 +3,7 @@ DESCRIPTION = "Initscripts provide the basic system 
>>> startup initialization scrip
>>>   SECTION = "base"
>>>   LICENSE = "GPLv2"
>>>   LIC_FILES_CHKSUM = 
>>> "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
>>> -PR = "r137"
>>> +PR = "r138"
>>>
>>>   INHIBIT_DEFAULT_DEPS = "1"
>>>
>>> @@ -133,4 +133,6 @@ do_install () {
>>>       fi
>>>
>>>       install -m 0755 ${WORKDIR}/device_table.txt 
>>> ${D}${sysconfdir}/device_table
>>> +    # Holds state information pertaining to urandom
>>> +    install -d ${D}/var/lib/urandom
>>
>> I thought this would go in volatiles, not here.
>>
>> Sau!
>>
> Hi Saul,
>
> From my understanding, volatiles is a configuration file which deals 
> with files related with volatile storage.
> Files, directories and links related to volatile storage should be in 
> this file, as it's a final method to check and make sure they are 
> created properly. But files under /var/lib should not there.

Hi, Saul:

Any comments? Should I send the V2 (put it into volatiles)?

the best,
thank you

>
> So in my option, this patch is ok.
>
> Thanks,
> Chen Qi
>
>>>   }
>>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>