From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mga09.intel.com ([134.134.136.24])
	by linuxtogo.org with esmtp (Exim 4.72)
	(envelope-from <sgw@linux.intel.com>) id 1TiV4r-0003Wk-JI
	for openembedded-core@lists.openembedded.org;
	Tue, 11 Dec 2012 20:01:14 +0100
Received: from orsmga002.jf.intel.com ([10.7.209.21])
	by orsmga102.jf.intel.com with ESMTP; 11 Dec 2012 10:45:50 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="4.84,260,1355126400"; d="scan'208";a="255930527"
Received: from unknown (HELO swold-linux.bigsur.com) ([10.255.13.105])
	by orsmga002.jf.intel.com with ESMTP; 11 Dec 2012 10:46:38 -0800
Message-ID: <50C77F8E.8030809@linux.intel.com>
Date: Tue, 11 Dec 2012 10:46:38 -0800
From: Saul Wold <sgw@linux.intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:17.0) Gecko/17.0 Thunderbird/17.0
MIME-Version: 1.0
To: "Shakeel, Muhammad" <muhammad_shakeel@mentor.com>
References: <1355213568-2341-1-git-send-email-muhammad_shakeel@mentor.com>
In-Reply-To: <1355213568-2341-1-git-send-email-muhammad_shakeel@mentor.com>
Cc: Christopher Larson <chris_larson@mentor.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] libacpi: Remove QA warning: No GNU_HASH in the elf binary
X-BeenThere: openembedded-core@lists.openembedded.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: Patches and discussions about the oe-core layer
	<openembedded-core.lists.openembedded.org>
List-Unsubscribe: <http://lists.linuxtogo.org/cgi-bin/mailman/options/openembedded-core>,
	<mailto:openembedded-core-request@lists.openembedded.org?subject=unsubscribe>
List-Archive: <http://lists.linuxtogo.org/pipermail/openembedded-core>
List-Post: <mailto:openembedded-core@lists.openembedded.org>
List-Help: <mailto:openembedded-core-request@lists.openembedded.org?subject=help>
List-Subscribe: <http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core>,
	<mailto:openembedded-core-request@lists.openembedded.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Dec 2012 19:01:14 -0000
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

On 12/11/2012 12:12 AM, Shakeel, Muhammad wrote:
> From: Muhammad Shakeel <muhammad_shakeel@mentor.com>
>
> Handle LDFLAGS properly in the Makefile to remove warning:
> QA Issue: No GNU_HASH in the elf binary
>
> Signed-off-by: Christopher Larson <chris_larson@mentor.com>
> Signed-off-by: Muhammad Shakeel <muhammad_shakeel@mentor.com>
> ---
>   meta/recipes-bsp/libacpi/files/ldflags.patch |   34 ++++++++++++++++++++++++++
>   meta/recipes-bsp/libacpi/libacpi_0.2.bb      |    3 ++-
>   2 files changed, 36 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-bsp/libacpi/files/ldflags.patch b/meta/recipes-bsp/libacpi/files/ldflags.patch
> new file mode 100644
> index 0000000..8049aa8
> --- /dev/null
> +++ b/meta/recipes-bsp/libacpi/files/ldflags.patch
> @@ -0,0 +1,34 @@

There is no patch header, this needs an Upstream-Status and Signed-off-by:

Thanks
	Sau!


> +---
> + Makefile  |    3 ++-
> + config.mk |    1 +
> + 2 files changed, 3 insertions(+), 1 deletion(-)
> +
> +--- libacpi-0.2.orig/Makefile
> ++++ libacpi-0.2/Makefile
> +@@ -19,6 +19,7 @@ options:
> + 	@echo "CFLAGS   = ${CFLAGS}"
> + 	@echo "CC       = ${CC}"
> + 	@echo "SOFLAGS  = ${SOFLAGS}"
> ++	@echo "LDFLAGS  = ${LDFLAGS}"
> + 	@echo "LD       = ${LD}"
> +
> + .c.o:
> +@@ -34,7 +35,7 @@ libacpi.a: ${OBJ}
> +
> + libacpi.so: ${OBJ}
> + 	@echo LD $@
> +-	@${CC} ${SOFLAGS} -o $@.${SOVERSION} ${OBJ}
> ++	@${CC} ${SOFLAGS} ${LDFLAGS} -o $@.${SOVERSION} ${OBJ}
> +
> + test-libacpi: ${OBJ_test}
> + 	@echo LD $@
> +--- libacpi-0.2.orig/config.mk
> ++++ libacpi-0.2/config.mk
> +@@ -10,6 +10,7 @@ MANPREFIX = ${PREFIX}/share/man
> + SOFLAGS = -shared -Wl,-soname,${SONAME}
> + CFLAGS += -fPIC -g --pedantic -Wall -Wextra
> + ARFLAGS = cr
> ++LDFLAGS =
> +
> + # Compiler and linker
> + CC = cc
> diff --git a/meta/recipes-bsp/libacpi/libacpi_0.2.bb b/meta/recipes-bsp/libacpi/libacpi_0.2.bb
> index b0fbf0b..f4c323d 100644
> --- a/meta/recipes-bsp/libacpi/libacpi_0.2.bb
> +++ b/meta/recipes-bsp/libacpi/libacpi_0.2.bb
> @@ -10,7 +10,8 @@ PR = "r6"
>   SRC_URI = "http://www.ngolde.de/download/libacpi-${PV}.tar.gz \
>   	   file://makefile-fix.patch \
>   	   file://libacpi_fix_for_x32.patch \
> -	   file://use_correct_strip_in_cross_environment.patch"
> +	   file://use_correct_strip_in_cross_environment.patch \
> +	   file://ldflags.patch "
>
>   SRC_URI[md5sum] = "05b53dd7bead66dda35fec502b91066c"
>   SRC_URI[sha256sum] = "13086e31d428b9c125954d48ac497b754bbbce2ef34ea29ecd903e82e25bad29"
>