Re: [PATCH 00/21][RFC v3] systemd Integration

[Radu Moisan <radu.moisan@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3532 bytes --]


On 01/14/2013 08:10 PM, Saul Wold wrote:
> On 01/14/2013 09:16 AM, Radu Moisan wrote:
>>
>> On 01/12/2013 01:23 AM, Saul Wold wrote:
>>> On 01/08/2013 04:24 AM, Radu Moisan wrote:
>>>> As Ross suggested I've done the following changes to the previous set:
>>>> * added two patches (the first two) that address multiple init
>>>> systems support,\
>>>> as in shifting from default hardcoded sysvinit to something more
>>>> generic while
>>>> the default values still remains on sysvinit
>>>> * moved automatic setting of PREFERRED_PROVIDER_udev into
>>>> default_providers.inc
>>>> * removed ahavi-systemd since all it provided was service files; now
>>>> service files
>>>> are pulled in by avahi-daemon
>>>> * also rebased on master
>>>>
>>>> The following changes since commit
>>>> 7e1f8faad0c4b6f490c26f87acc698dd6e002b15:
>>>>
>>>>    perl: Remove bashism from perl-tests.inc (2013-01-07 22:37:37 
>>>> +0000)
>>>>
>>>> are available in the git repository at:
>>>>
>>>>    git://git.yoctoproject.org/poky-contrib rmoisan/systemd
>>>> http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=rmoisan/systemd 
>>>>
>>>>
>>>> Enrico Scholz (1):
>>>>    systemd: move disable operation into prerm() script
>>>>
>>>> Holger Hans Peter Freyther (2):
>>>>    systemd: Make the main systemd files proper CONFFILES
>>>>    systemd: Introduce a create-volatile to create tmp directories
>>> White space 4 spaces vs tab
>>
>> Fixed.
>>
>>>
>>>>
>>>> Khem Raj (1):
>>>>    systemd: Fix build when base_libdir is not /lib
>>>>
>>>> Martin Donnelly (2):
>>>>    cgroups: Add INSANE_SKIP to avoid warning about .so file
>>>>    systemd: Remove sysvinit mount related services if systemd is 
>>>> enabled
>>>>
>>>> Martin Jansa (2):
>>>>    systemd: fix FILESPATH to find systemctl
>>>>    systemd: add PACKAGES_DYNAMIC
>>>>
>>>> Radu Moisan (13):
>>>>    default-distrovars: Add DISTRO_FEATURES_INITMAN to DISTRO_FEATURES
>>>>    default-providers: Automatically set PREFERRED_PROVIDER_udev
>>>>    systemd: initial integration
>>> I believe this was mentioned before, but can you avoid making white
>>> space changes, you seem to have changed tabs (which we use tabs for
>>> shell based functions and 4 spaces for python based functions)
>>>
>>> Specifically, I saw some changes in wpa-supplicant-1.0.inc, busybox,
>>> dropbear, initscripts
>>>
>> Reviewed those files and cleaned them up to comply.
>>
> I am still seeing white space changes, as mentioned before if you want 
> to cleanup white space changes, make that a separate and distinct 
> patch, so for instance in dropbear you un-indented some SRC_URIs, that 
> should be a distinct patch with white space changes only separate from 
> the addition of the dropbear*.service files.
>
> I know I might be getting a little nit-picky, but it's about 
> readability and understanding the change sets, I just stop looking 
> because it's hard to see the changes clearly.
>
> So please check you whitespace and sent a seperate whitespace fixup 
> patch.

You need to get to an understanding with Ross. He suggested to get rid 
if white space patches, and squash them so that only relevant changes 
would appear in the history.
About the spaces vs tab problem, I tried to fix that yesterday in the 
files you mentioned, and indeed I fixed it for the entire file. I 
understand it would make reviewing harder, but you can always use -w 
option with git show or git diff to ignore white spaces.

Radu

[-- Attachment #2: Type: text/html, Size: 6043 bytes --]