From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com ([134.134.136.20]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1TvmNU-0002bO-F0 for openembedded-core@lists.openembedded.org; Thu, 17 Jan 2013 11:07:21 +0100 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 17 Jan 2013 01:51:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.84,484,1355126400"; d="scan'208";a="273172074" Received: from lpalcu-linux (HELO [10.237.105.165]) ([10.237.105.165]) by orsmga002.jf.intel.com with ESMTP; 17 Jan 2013 01:51:52 -0800 Message-ID: <50F7C9B7.9030002@intel.com> Date: Thu, 17 Jan 2013 11:51:51 +0200 From: Laurentiu Palcu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Hongxu Jia References: <4dc1347ed4057656a542263878aeeadf768dd2e9.1358406049.git.hongxu.jia@windriver.com> <50F7C020.8090505@intel.com> <50F7C6DA.9030502@windriver.com> In-Reply-To: <50F7C6DA.9030502@windriver.com> Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH 1/4] gtk-icon-cache.bbclass:fix support postrm at image creation time X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2013 10:07:21 -0000 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On 01/17/2013 11:39 AM, Hongxu Jia wrote: > On 01/17/2013 05:10 PM, Laurentiu Palcu wrote: >> >> On 01/17/2013 09:07 AM, Hongxu Jia wrote: >>> gtk_icon_cache_postrm() { >>> +if [ "$D" != "" ]; then >>> + for icondir in $D/usr/share/icons/* ; do >>> + if [ -d $icondir ] ; then >>> + gtk-update-icon-cache -qt $icondir >>> + fi >>> + done >>> + exit 0 >>> +fi >> I think you can just exit 0 here and let the hook in intercept-scripts >> directory do the rest. The hook was added in the postinst and it will >> properly call gtk-update-icon-cache. If you look in the log.do_rootfs >> you'll see that the intercept scripts are run at the end (just look for >> "Running intercept scripts"). So, I don't think you need to do this loop >> here. Besides, it will be called for every postrm and running >> gtk-update-icon-cache is not cheap... >> >> Thanks, >> Laurentiu > Ok, I will work on it to let the hook in intercept-scripts do the rest. I just realized that, in order for the hook to be installed, the postint scriptlet has to be run in the same do_rootfs session, otherwise the hook will not be installed... In which case you might want to do that in the postrm itself (like it was done for postinst). Thanks, Laurentiu > > Thanks, > Hongxu >