Re: [PATCH 1/4] gtk-icon-cache.bbclass:fix support postrm at image creation time

Hongxu Jia
2013-01-17T09:55:13Z

On 01/17/2013 05:10 PM, Laurentiu Palcu wrote:
>
> On 01/17/2013 09:07 AM, Hongxu Jia wrote:
>> gtk_icon_cache_postrm() {
>> +if [ "$D" != "" ]; then
>> + for icondir in $D/usr/share/icons/* ; do
>> + if [ -d $icondir ] ; then
>> + gtk-update-icon-cache -qt $icondir
>> + fi
>> + done
>> + exit 0
>> +fi
> I think you can just exit 0 here and let the hook in intercept-scripts
> directory do the rest. The hook was added in the postinst and it will
> properly call gtk-update-icon-cache. If you look in the log.do_rootfs
> you'll see that the intercept scripts are run at the end (just look for
> "Running intercept scripts"). So, I don't think you need to do this loop
> here. Besides, it will be called for every postrm and running
> gtk-update-icon-cache is not cheap...
>
> Thanks,
> Laurentiu
Ok, I will work on it to let the hook in intercept-scripts do the rest.

Thanks,
Hongxu