public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Hongxu Jia <hongxu.jia@windriver.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 4/4] gtk-immodules-cache.bbclass:fix support postrm at image creation time
Date: Thu, 17 Jan 2013 18:38:14 +0800	[thread overview]
Message-ID: <50F7D496.3060601@windriver.com> (raw)
In-Reply-To: <CAJTo0La=D3TTZBkEytV3WoYHYFZOX8Ubs3C_rGfhdMHjj6NDzg@mail.gmail.com>

On 01/17/2013 05:52 PM, Burton, Ross wrote:
> On 17 January 2013 07:07, Hongxu Jia <hongxu.jia@windriver.com> wrote:
>> Let gtk_immodule_cache_postrm exit with ok at image creation time
>>
>> [YOCTO #3633]
>>
>> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
>> ---
>>   meta/classes/gtk-immodules-cache.bbclass |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/gtk-immodules-cache.bbclass b/meta/classes/gtk-immodules-cache.bbclass
>> index 9ffb03b..6e1f5ef 100644
>> --- a/meta/classes/gtk-immodules-cache.bbclass
>> +++ b/meta/classes/gtk-immodules-cache.bbclass
>> @@ -31,7 +31,7 @@ fi
>>
>>   gtk_immodule_cache_postrm() {
>>   if [ "x$D" != "x" ]; then
>> -    exit 1
>> +    exit 0
>>   fi
>>   if [ ! -z `which gtk-query-immodules-2.0` ]; then
>>       gtk-query-immodules-2.0 > /etc/gtk-2.0/gtk.immodules
> Surely you still want to run the postrm, and by exiting with 0 you're
> not deferring it.  Can't this use the same logic as the postinst to
> run on both build machine and target?
>
> Ross
No problem, I will use the same logic as the postinst to do that.

Thanks,
Hongxu



  reply	other threads:[~2013-01-17 10:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-17  7:07 [PATCH 0/4]fix support postrm/prerm at image creation time Hongxu Jia
2013-01-17  7:07 ` [PATCH 1/4] gtk-icon-cache.bbclass:fix support postrm " Hongxu Jia
2013-01-17  9:10   ` Laurentiu Palcu
2013-01-17  9:39     ` Hongxu Jia
2013-01-17  9:51       ` Laurentiu Palcu
2013-01-17  9:26   ` Martin Jansa
2013-01-17  7:07 ` [PATCH 2/4] update-rc.d:fix " Hongxu Jia
2013-01-17  7:07 ` [PATCH 3/4] libnss-mdns:fix support prerm " Hongxu Jia
2013-01-17  9:28   ` Martin Jansa
2013-01-17 10:48     ` Hongxu Jia
2013-01-17 12:35       ` Martin Jansa
2013-01-17  7:07 ` [PATCH 4/4] gtk-immodules-cache.bbclass:fix support postrm " Hongxu Jia
2013-01-17  9:52   ` Burton, Ross
2013-01-17 10:38     ` Hongxu Jia [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-01-17 12:56 [PATCH V2 0/4]fix support postrm/prerm " Hongxu Jia
2013-01-17 12:56 ` [PATCH 4/4] gtk-immodules-cache.bbclass:fix support postrm " Hongxu Jia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50F7D496.3060601@windriver.com \
    --to=hongxu.jia@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox