From: Saul Wold <sgw@linux.intel.com>
To: Holger Hans Peter Freyther <holger@moiji-mobile.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] archiver.bbclass: Archive the native builds as well
Date: Fri, 18 Jan 2013 10:25:43 -0800 [thread overview]
Message-ID: <50F993A7.30308@linux.intel.com> (raw)
In-Reply-To: <1358519642-31022-1-git-send-email-holger@moiji-mobile.com>
On 01/18/2013 06:34 AM, Holger Hans Peter Freyther wrote:
> On my build no copy of gcc/opkg-utils was archived. For gcc it is
> bad as libgcc will end up in the image and the sources should be
> provided. Update the method and comment to not exclude the native
> version of the build.
I understand what the issue is here, but I am not sure this is the right
solution. This will likely bring in way more than is wanted or needed
for source archiving.
What's needed from the opkg-utils-native?
Sau!
> ---
> meta/classes/archiver.bbclass | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/archiver.bbclass b/meta/classes/archiver.bbclass
> index a4a2158..516f947 100644
> --- a/meta/classes/archiver.bbclass
> +++ b/meta/classes/archiver.bbclass
> @@ -187,11 +187,11 @@ def get_applying_patches(d):
>
> def not_tarball(d):
> """
> - packages including key words 'work-shared', 'native', 'packagegroup-' will be passed
> + packages including key words 'work-shared', 'packagegroup-' will be passed
> """
> workdir = d.getVar('WORKDIR', True)
> s = d.getVar('S', True)
> - if 'work-shared' in s or 'packagegroup-' in workdir or 'native' in workdir:
> + if 'work-shared' in s or 'packagegroup-' in workdir:
> return True
> else:
> return False
>
next prev parent reply other threads:[~2013-01-18 18:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 14:34 [PATCH] archiver.bbclass: Archive the native builds as well Holger Hans Peter Freyther
2013-01-18 18:24 ` kevin.strasser
2013-01-18 18:35 ` Saul Wold
2013-01-18 18:25 ` Saul Wold [this message]
2013-01-19 8:44 ` Holger Hans Peter Freyther
2013-01-20 12:56 ` Richard Purdie
2013-01-20 15:47 ` Holger Hans Peter Freyther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F993A7.30308@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=holger@moiji-mobile.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox