From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.windriver.com ([147.11.1.11]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1Tze01-00057B-5k for openembedded-core@lists.openembedded.org; Mon, 28 Jan 2013 02:59:05 +0100 Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail.windriver.com (8.14.5/8.14.3) with ESMTP id r0S1hObi008165 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Sun, 27 Jan 2013 17:43:24 -0800 (PST) Received: from [128.224.162.207] (128.224.162.207) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.2.328.9; Sun, 27 Jan 2013 17:43:24 -0800 Message-ID: <5105D7C1.6040700@windriver.com> Date: Mon, 28 Jan 2013 09:43:29 +0800 From: Pascal Ouyang User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: lei yang References: <1359026733-1392-1-git-send-email-Xin.Ouyang@windriver.com> <51039E47.8090701@windriver.com> In-Reply-To: X-TagToolbar-Keys: D20130128094329037 X-MIME-Autoconverted: from 8bit to quoted-printable by mail.windriver.com id r0S1hObi008165 Cc: openembedded-core@www.linuxtogo.org, openembedded-core@lists.openembedded.org Subject: Re: [V2 PATCH] libcgroup: fix the QA issue for pam_cgroup.so* X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jan 2013 01:59:05 -0000 Content-Type: text/plain; charset="GB2312" Content-Transfer-Encoding: quoted-printable =D3=DA 2013=C4=EA01=D4=C226=C8=D5 18:33, lei yang =D0=B4=B5=C0: > On Sat, Jan 26, 2013 at 5:13 PM, Pascal Ouyang wrote: >> =D3=DA 2013=C4=EA01=D4=C224=C8=D5 19:25, Xin Ouyang =D0=B4=B5=C0: >> >>> PAM modules in ${base_libdir}/security/ should be binary .so files, >>> not symlinks, so fix this. Since pam_cgroup.so is installed into >>> ${base_libdir}/security, move libcgroup.so.* to ${base_libdir} to >>> avoid "unsafe-references-in-binaries" QA issue. >>> >>> Signed-off-by: Xin Ouyang >>> --- >>> meta/recipes-core/libcgroup/libcgroup_0.37.1.bb | 15 +++++++++++= ++-- >>> 1 file changed, 13 insertions(+), 2 deletions(-) >>> >>> diff --git a/meta/recipes-core/libcgroup/libcgroup_0.37.1.bb >>> b/meta/recipes-core/libcgroup/libcgroup_0.37.1.bb >>> index e74f831..d217f7b 100644 >>> --- a/meta/recipes-core/libcgroup/libcgroup_0.37.1.bb >>> +++ b/meta/recipes-core/libcgroup/libcgroup_0.37.1.bb >>> @@ -23,5 +23,16 @@ FILES_cgroups-pam-plugin =3D >>> "${base_libdir}/security/pam_cgroup.so*" >>> FILES_${PN}-dbg +=3D "${base_libdir}/security/.debug" >>> FILES_${PN}-dev +=3D "${base_libdir}/security/*.la" >>> >>> -# We really need the symlink so :( >>> -INSANE_SKIP_cgroups-pam-plugin =3D "dev-so" >>> +do_install_append() { >>> + # Moving libcgroup to base_libdir >>> + if [ ! ${D}${libdir} -ef ${D}${base_libdir} ]; then >>> + mkdir -p ${D}/${base_libdir}/ >>> + mv -f ${D}${libdir}/libcgroup.so.* ${D}${base_libdir}= / >>> + ln -sf ${D}${base_libdir}/libcgroup.so.1 >>> ${D}${libdir}/libcgroup.so >> >> >> I should not use absolute path for this symlink here. >> >> rel_lib_prefix=3D`echo ${libdir} | sed 's,\(^/\|\)[^/][^/]*,..,g'` >> ln -sf ${rel_lib_prefix}${base_libdir}/libcgroup.so.1 \ >> >=20 > I think use >=20 > cd ${D} > ln -sf libcgroup.so.1 ${D}${libdir}/libcgroup.so >=20 > should be OK, no need sed to handle libcgroup.so.1 is now moved to ${base_libdir}, so just sed. :) - Pascal >=20 >=20 > Lei >=20 >> ${D}${libdir}/libcgroup.so >> >> V3 will be sent. Thanks. >> >> - Pascal >> >> >>> + fi >>> + # pam modules in ${base_libdir}/security/ should be binary .s= o >>> files, not symlinks. >>> + if [ -f ${D}${base_libdir}/security/pam_cgroup.so.0.0.0 ]; th= en >>> + mv -f ${D}${base_libdir}/security/pam_cgroup.so.0.0.0 >>> ${D}${base_libdir}/security/pam_cgroup.so >>> + rm -f ${D}${base_libdir}/security/pam_cgroup.so.* >>> + fi >>> +} >>> >> >> >> >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >=20 >=20 --=20 - Pascal