Re: [PATCH 4/8] Revert "Add ptest for glib."

Saul Wold
2013-02-05T20:15:00Z

On 02/05/2013 11:36 AM, Bernhard Reutner-Fischer wrote:
> On 5 February 2013 20:16, Bernhard Reutner-Fischer
> <rep.dot.nop@gmail.com> wrote:
>> On 5 February 2013 19:39, Saul Wold <sgw@linux.intel.com> wrote:
>>> On 02/05/2013 09:13 AM, Bernhard Reutner-Fischer wrote:
>>>>
>>>> On 5 February 2013 17:46, Saul Wold <sgw@linux.intel.com> wrote:
>>>>>
>>>>> On 02/05/2013 07:55 AM, Bernhard Reutner-Fischer wrote:
>>>>>>
>>>>>>
>>>>>> This reverts commit dec6f912d68f52748f645b6af411f189cf464f85.
>>>>>>
>>>>>> This breaks core-image-sato-sdk for TCLIBC="uclibc".
>>>>>>
>>>>> What's the issue? Is it fixable instead of reverting the ptest patch? I
>>>>
>>>>
>>>> The issue is that it incorrectly and unconditionally pulls in eglibc
>>>> stuff:
>>>>
>>>> -RDEPENDS_${PN}-ptest += "\
>>>> - eglibc-gconv-utf-16 \
>>>> - eglibc-charmap-utf-8 \
>>>> - eglibc-gconv-cp1255 \
>>>> - eglibc-charmap-cp1255 \
>>>> - eglibc-gconv-utf-32 \
>>>> - eglibc-gconv-utf-7 \
>>>> - eglibc-charmap-invariant \
>>>> - eglibc-localedata-translit-cjk-variants \
>>>> - tzdata \
>>>> - tzdata-americas \
>>>> - tzdata-asia \
>>>> - tzdata-europe \
>>>> - tzdata-posix \
>>>> - python-pygobject \
>>>> - python-dbus \
>>>> - "
>>>>
>>> Bjorn,
>>>
>>> Do you have some time to look at this and see if you can make use of TCLIBC
>>> to use the correct library and locale package info based on which libc is
>>> being used?
>>
>> would most likely DTRT, yep.
>
> Well, given that i see e.g. glibc-gconv-utf-16 nowhere in
> openembedded-core i suspect they are misplaced and should live in the
> layer that provides them.
>
It's a DYNAMIC package built in eglibc-locale.inc.

>> I'm curious what you would need from uClibc to satisfy that ptest thing?
>> What does it do, what is it good for? :)
>
Bjorn question at this point!

> Is e.g. glibc-gconv-utf-16 locale support or something like that?
>
probably, could the uclibc-gconv provide equivalent?

Sau!

> thanks,
>>
>> RDEPENDS_${PN}-ptest += "\
>> tzdata \
>> tzdata-americas \
>> tzdata-asia \
>> tzdata-europe \
>> tzdata-posix \
>> python-pygobject \
>> python-dbus \
>> "
>> RDEPENDS_${PN}-ptest_append_libc-eglibc = "\
>> eglibc-gconv-utf-16 \
>> eglibc-charmap-utf-8 \
>> eglibc-gconv-cp1255 \
>> eglibc-charmap-cp1255 \
>> eglibc-gconv-utf-32 \
>> eglibc-gconv-utf-7 \
>> eglibc-charmap-invariant \
>> eglibc-localedata-translit-cjk-variants \
>> "
>> RDEPENDS_${PN}-ptest_append_libc-eglibc = "did not look"
>>
>> TIA && cheers,
>
>