public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Darren Hart <dvhart@linux.intel.com>
To: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>,
	Otavio Salvador <otavio@ossystems.com.br>,
	Darren Hart
	<public-dvhart-VuQAYsv1563Yd54FQh9/CA@plane.gmane.org>
Subject: Re: [PATCH 7/8] oe-git-proxy.sh: Add a new comprehensive git proxy script
Date: Tue, 05 Feb 2013 11:18:33 -0800	[thread overview]
Message-ID: <51115B09.9090607@linux.intel.com> (raw)
In-Reply-To: <lyhalq4lz0.fsf@ensc-virt.intern.sigma-chemnitz.de>



On 02/05/2013 11:08 AM, Enrico Scholz wrote:
> Otavio Salvador <otavio@ossystems.com.br> writes:
> 
>> Please give it a try in dash as well.
> 
> fwiw, what's the point in writing such scripts plain sh?  I guess. every
> machine where this script is running has /bin/bash and performance is
> not critical for it. Using '#! /bin/bash' shebang fixes the problem
> where sh is non bash.
> 
> Some constructs in the scripts can be expressed mor efficiently in bash
> (e.g. the '... | sed' statements, or using arrays for the arguments).

Indeed, in fact I had to remove the bash parameter expansions
(substrings, etc) I had in my original script in order to make it
dash-able. I hate dash and personally find it to be completely
pointless, but for better or worse, people like it and there is an
expectation that scripts run in both dash and bash in OE-core.

If RP tells me a #!/bin/bash is acceptable, I'll restore the bashisms in
a heartbeat.

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel



  reply	other threads:[~2013-02-05 19:34 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-05 10:31 [PATCH 0/8] Git fetcher and proxy handling updates Darren Hart
2013-02-05 10:31 ` [PATCH 1/8] bitbake: fetch2: Print the complete SRCREV variable name when INVALID Darren Hart
2013-02-05 10:31 ` [PATCH 2/8] bitbake: fetch2: Export upper and lower case environment variables Darren Hart
2013-02-05 10:31 ` [PATCH 3/8] bitbake: fetch2: Remove broken git variables from the environment Darren Hart
2013-02-05 10:31 ` [PATCH 4/8] oe-buildenv-internal: Remove GIT variables from BB_ENV_EXTRAWHITE Darren Hart
2013-02-05 10:31 ` [PATCH 5/8] oe-buildenv-internal: Add upper and lower case proxy vars to BB_ENV_EXTRAWHITE Darren Hart
2013-02-05 10:31 ` [PATCH 6/8] base.bbclass: Remove generate_git_config() Darren Hart
2013-02-05 10:31 ` [PATCH 7/8] oe-git-proxy.sh: Add a new comprehensive git proxy script Darren Hart
2013-02-05 11:16   ` Enrico Scholz
2013-02-05 16:20     ` Darren Hart
2013-02-05 16:36       ` Enrico Scholz
2013-02-05 17:44         ` Darren Hart
2013-02-05 18:40           ` Otavio Salvador
2013-02-05 18:50             ` Darren Hart
2013-02-05 19:08             ` Enrico Scholz
2013-02-05 19:18               ` Darren Hart [this message]
2013-02-05 19:29                 ` Otavio Salvador
2013-02-05 22:10                 ` Richard Purdie
2013-02-05 10:31 ` [PATCH 8/8] git proxy: Document usage of oe-git-proxy.sh and remove alternatives Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51115B09.9090607@linux.intel.com \
    --to=dvhart@linux.intel.com \
    --cc=enrico.scholz@sigma-chemnitz.de \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=otavio@ossystems.com.br \
    --cc=public-dvhart-VuQAYsv1563Yd54FQh9/CA@plane.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox