Re: [PATCH v2 0/3] relocate_sdk.py: improvements

[Jason Wessel <jason.wessel@windriver.com>]

On 02/12/2013 02:09 AM, Laurentiu Palcu wrote:
>
>
> On 02/12/2013 01:22 AM, Jason Wessel wrote:
>> Now that I have had to debug the SDK relocator on multiple occasions
>> I figure it might be nice to get the patches upstreamed.
> But, before that, did you see my comments on the previous patchset? It
> looks like they went unnoticed as they were not addressed.
>
> Here is what I replied to your previous patches:
> http://lists.linuxtogo.org/pipermail/openembedded-core/2013-January/034868.html
> http://lists.linuxtogo.org/pipermail/openembedded-core/2013-January/034869.html

For what ever reason I never received the original mails, else I absolutely would have responded.  This is the first response I have received from the oe-core list in months in fact.

To answer your question you posed in the threads above, I'll do it right here due to the lack of the originals.

>> - dl_path = new_dl_path + "\0" * (p_filesz - len(new_dl_path))
> Personally, I would prefer you left the zero padding in place.
> Otherwise, if installing in a location like /opt/test the .interp
> section would look like below. Technically, the dynamic loader would not
> care but it would be nice to have a clean .interp section, without
> leftover strings in it...
>
> This is how it would look like after relocation:
> $ readelf -p .interp qemu-arm
>
> String dump of section '.interp':
> [ 0] /opt/test/sysroots/x86_64-pokysdk-linux/lib/ld-linux-x86-64.so.2
> [ 41] -x86-64.so.2


I completely agree with you.  This will be fixed in v3.

>> +echo "#!/bin/bash" > ${env_setup_script%/*}/relocate_sdk.sh
>> +echo exec $SUDO_EXEC ${env_setup_script%/*}/relocate_sdk.py $target_sdk_dir $dl_path $executable_files >> ${env_setup_script%/*}/relocate_sdk.sh
>> +chmod 755 ${env_setup_script%/*}/relocate_sdk.sh
> The last 3 lines will certainly fail if installation takes place in a
> location you don't have rights... So, you'll end up with no
> relocate_sdk.sh script.

Easy enough to fix, I'll fix this shortly.  Many thanks for your comments.

Cheers,
Jason.