From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail1.windriver.com ([147.11.146.13]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1U5NvC-0005na-QF for openembedded-core@lists.openembedded.org; Tue, 12 Feb 2013 23:01:51 +0100 Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail1.windriver.com (8.14.5/8.14.3) with ESMTP id r1CLjoDu005630 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL) for ; Tue, 12 Feb 2013 13:45:50 -0800 (PST) Received: from msp-dhcp44.wrs.com (172.25.34.44) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.2.318.4; Tue, 12 Feb 2013 13:45:49 -0800 Message-ID: <511AB804.40704@windriver.com> Date: Tue, 12 Feb 2013 15:45:40 -0600 From: Mark Hatle Organization: Wind River Systems User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 MIME-Version: 1.0 To: References: <1360697804-39039-1-git-send-email-jason.wessel@windriver.com> <1360705147.30425.70.camel@ted> In-Reply-To: <1360705147.30425.70.camel@ted> Subject: Re: [PATCH] libtool-native_2.4.2.bb: Always use /bin/sed for SED X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2013 22:01:51 -0000 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit On 2/12/13 3:39 PM, Richard Purdie wrote: > On Tue, 2013-02-12 at 13:36 -0600, Jason Wessel wrote: >> If you never use sstate and always build everything from scratch you >> will never see this problem. However, if you use sstate and build >> directories that last a long time eventually you can end up with the >> scenario where libtool gets a hard coded path in it for sed, and sed >> may not exist. The reason you don't see this problem to often if you >> generally build from scratch is that libtool builds before sed and >> will pickup the host's /bin/sed. >> >> The way to reproduce the issue is: >> >> bitbake some_image >> bitbake -c cleansstate libtool-native >> bitbake sed-native >> bitbake libtool-native >> bitbake -c clean sed-native >> bitbake ANY_PACKAGE_THAT_USES_LIBTOOL_NATIVE >> >> In my case I used modphp, which doesn't exist in the oe-core. You will >> end up with a strange looking error like: >> >> | make[1]: *** [buckets/apr_buckets_alloc.lo] Error 1 >> | /opt/build/bitbake_build/tmp/sysroots/x86_64-linux/usr/bin/x86_64-linux-libtool: line 981: /opt/build/bitbake_build/tmp/sysroots/x86_64-linux//bin/sed: No such file or directory >> >> The solution is to always use /bin/sed for libtool-native. >> >> Signed-off-by: Jason Wessel >> --- >> .../libtool/libtool-native_2.4.2.bb | 3 ++- >> 1 files changed, 2 insertions(+), 1 deletions(-) >> >> diff --git a/meta/recipes-devtools/libtool/libtool-native_2.4.2.bb b/meta/recipes-devtools/libtool/libtool-native_2.4.2.bb >> index f12e6a1..18188ef 100644 >> --- a/meta/recipes-devtools/libtool/libtool-native_2.4.2.bb >> +++ b/meta/recipes-devtools/libtool/libtool-native_2.4.2.bb >> @@ -2,12 +2,13 @@ require libtool-${PV}.inc >> >> DEPENDS = "" >> >> -PR = "${INC_PR}.0" >> +PR = "${INC_PR}.1" >> SRC_URI += "file://prefix.patch" >> >> inherit native >> >> EXTRA_OECONF = " --with-libtool-sysroot=${STAGING_DIR_NATIVE}" >> +CACHED_CONFIGUREVARS += "ac_cv_path_SED=/bin/sed" > > Do we have to set a path for it? Can't we rely on PATH being sane? I'm > wondering if we should actually set this in the core site files. > Hardcoding a path to utilities never usually ends well and this is just > the tip of an iceberg. > > If we have to use a path, "${bindir}/env sed"? We considered this. The problem w/ using env to call sed is there is a small window where the sed-native is being constructed, that we can have a failure. --Mark > Cheers, > > Richard > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >