public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Khem Raj <raj.khem@gmail.com>
To: Nicolas Dechesne <nicolas.dechesne@linaro.org>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] gstreamer1.0-plugins-bad: add packageconfig for egl
Date: Fri, 26 Aug 2016 16:39:05 -0700	[thread overview]
Message-ID: <51219ed0-b8e7-4bdf-c3c3-7812dcc59cd0@gmail.com> (raw)
In-Reply-To: <1472219341-21220-1-git-send-email-nicolas.dechesne@linaro.org>



On 8/26/16 6:49 AM, Nicolas Dechesne wrote:
> In commit 9c3a94aea1d (gstreamer1.0-plugins-bad: Move EGL requirement for
> Wayland), --enable-egl was explicitely added to the wayland packageconfig. While
> this is correct that enabling wayland requires egl, it should be possible to
> enable egl without wayland, even when using X11. For example, glimagesink can be
> used for GPU based color conversion using EGL/GLES.

the default PACKAGECONFIG coming out of recipe should append 'egl'
unconditionally, if wayland is set in DISTRO_FEATURES. otherwise it will
confuse the semantics if its hardcoded in packageocnfig for wayland

> 
> Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>
> ---
>  meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
> index d8c8179..1a94d1a 100644
> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
> @@ -32,6 +32,7 @@ PACKAGECONFIG[curl]            = "--enable-curl,--disable-curl,curl"
>  PACKAGECONFIG[dash]            = "--enable-dash,--disable-dash,libxml2"
>  PACKAGECONFIG[directfb]        = "--enable-directfb,--disable-directfb,directfb"
>  PACKAGECONFIG[dtls]            = "--enable-dtls,--disable-dtls,openssl"
> +PACKAGECONFIG[egl]             = "--enable-egl,--disable-egl,virtual/egl"
>  PACKAGECONFIG[faac]            = "--enable-faac,--disable-faac,faac"
>  PACKAGECONFIG[faad]            = "--enable-faad,--disable-faad,faad2"
>  PACKAGECONFIG[flite]           = "--enable-flite,--disable-flite,flite-alsa"
> 


      reply	other threads:[~2016-08-26 23:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-26 13:49 [PATCH] gstreamer1.0-plugins-bad: add packageconfig for egl Nicolas Dechesne
2016-08-26 23:39 ` Khem Raj [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51219ed0-b8e7-4bdf-c3c3-7812dcc59cd0@gmail.com \
    --to=raj.khem@gmail.com \
    --cc=nicolas.dechesne@linaro.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox