Re: [PATCH V2 4/5] populate-volatile.sh: improve the handling of link config items

[ChenQi <Qi.Chen@windriver.com>]

On 02/20/2013 05:18 PM, Bernhard Reutner-Fischer wrote:
> On 20 February 2013 08:16, ChenQi <Qi.Chen@windriver.com> wrote:
>> On 02/20/2013 03:10 PM, Bernhard Reutner-Fischer wrote:
>>> On 20 February 2013 06:55:33 <Qi.Chen@windriver.com> wrote:
>>>> From: Chen Qi <Qi.Chen@windriver.com>
>>>>
>>>> Previously, if there's a link config item in the config file like
>>>>
>>>>          l root root 1777 /tmp /var/tmp
>>>>
>>>> and /tmp has existed, the symlink will not be created correctly.
>>>>
>>>> Another example is the /run directory. If /run directory has been
>>>> created by some recipe or script before populate-volatile.sh runs,
>>>> the symlink of /run to /var/run will not be created correctly.
>>>>
>>>> This patch ensures that the system creates symlinks exactly as the
>>>> config file tells it.
>>>
>>> This one also has bugs in background handling, it seems.
>>
>> What's the bug?
> -                               link_file "${TSOURCE}" "${TNAME}" &
> -                       }
> +                       [ "${VERBOSE}" != "no" ] && echo "Creating
> link -${TNAME}- pointing to -${TSOURCE}-."
> +                       link_file "${TSOURCE}" "${TNAME}"
>
> missing '&' after the link_file.
Thanks. I'll resend out this patch.

>>
>>> Can't you massage stderr redirection when setting EXIT instead?
>>
>> Could you please be more specific?
> I meant EXEC.
> Can't you put the > /dev/null 2>&1 into the relevant parts of _all_
> the EXEC instead, in the whole series?
>
I don't think so :(
Only in case of running at rootfs time can we ignore the errors.

Best Regards,
Chen Qi

>>>> [YOCTO #3404]
>>>> [YOCTO #3406]
>