From: Jack Mitchell <ml@communistcode.co.uk>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] connman: enable connman client
Date: Sat, 23 Feb 2013 09:02:07 +0000 [thread overview]
Message-ID: <5128858F.1030107@communistcode.co.uk> (raw)
In-Reply-To: <7EF31BEB21E340DBAFB08ABD4321A269@intel.com>
On 02/23/13 08:34, Ross Burton wrote:
> Hi Cristian,
>
> On Friday, 22 February 2013 at 20:10, Cristian Iorga wrote:
>> - --disable-client \
> I'd prefer to see an explicit --enable-client here to make it clear what we're turning on and off.
>
>> + install -m 0755 ${S}/client/connmanctl ${D}${bindir}
> ${S} (source) should be ${B} (build), although at the moment they are the same directory I've been slowly working on changing that.
>
> Also the fact that you have to do this is depressing. I wonder why upstream doesn't want to install any of the tools?
Connmanctl is a helper, even though I have connman in my image, I
wouldn't want connmanctl. I assume this is why they don't ship it by
default; as my use case is fairly normal for connman.
Which leads to the next point, this should be a seperate package.
>
> Ross
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
next prev parent reply other threads:[~2013-02-23 9:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 20:10 [PATCH] connman: enable connman client Cristian Iorga
2013-02-23 8:34 ` Ross Burton
2013-02-23 9:02 ` Jack Mitchell [this message]
2013-02-23 11:30 ` Paul Eggleton
2013-02-23 12:43 ` Jack Mitchell
2013-02-25 7:18 ` Iorga, Cristian
2013-02-25 8:21 ` Burton, Ross
2013-02-25 7:36 ` Iorga, Cristian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5128858F.1030107@communistcode.co.uk \
--to=ml@communistcode.co.uk \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox