Re: [PATCH 1/1] sysvinit: start .sh scripts correctly

[Saul Wold <sgw@linux.intel.com>]

On 02/25/2013 05:39 PM, Qi.Chen@windriver.com wrote:
> From: Chen Qi <Qi.Chen@windriver.com>
>
> Previously, scripts which end with '.sh' were sourced, so the arguments
> like 'start' and 'stop' were just ignored.
>
> This resulted in some init scripts not being able to start correctly.
> For example, sourcing hwclock.sh in busybox actually does nothing.
> It should be invoked as 'hwclock.sh start' or 'hwclock.sh stop'.
>
> This patch fixes this issue.
>
> [YOCTO #3612]
>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
>   meta/recipes-core/sysvinit/sysvinit/rc |   16 +---------------
>   1 file changed, 1 insertion(+), 15 deletions(-)
>
> diff --git a/meta/recipes-core/sysvinit/sysvinit/rc b/meta/recipes-core/sysvinit/sysvinit/rc
> index 44bc9bf..50951da 100755
> --- a/meta/recipes-core/sysvinit/sysvinit/rc
> +++ b/meta/recipes-core/sysvinit/sysvinit/rc
> @@ -41,21 +41,7 @@ startup_progress() {
>   startup() {
>     # Handle verbosity
>     [ "$VERBOSE" = very ] && echo "INIT: Running $@..."
> -
> -  case "$1" in
> -	*.sh)
> -		# Source shell script for speed.
> -		(
> -			trap - INT QUIT TSTP

Are you sure you don't want the trap still?  I realize this reset it to 
default..

Sau!

> -			scriptname=$1
> -			shift
> -			. $scriptname
> -		)
> -		;;
> -	*)
> -		"$@"
> -		;;
> -  esac
> +  "$@"
>     startup_progress
>   }
>
>