Re: [PATCH] base-files: fix 'dash' expanding '\n'

[Javier Viguera <javier.viguera@digi.com>]

Hi all,

I just saw this patch i sent last week was pushed to 
openembedded-core/poky *master* branches. Thanks for that.

But in my development i am using stable 'danny' branches.

Any chance that this patch gets cherry-picked to 'danny' on 
openembedded-core and poky repos?

-
Javier Viguera
Software Engineer
Digi International® Spain S.A.U.


On 02/20/2013 04:09 PM, Javier Viguera wrote:
> Dash's 'echo' command expands '\n' by default, so the '\n' is not
> included in the '/etc/issue' file.
>
> Use 'printf' for portability between different shells.
>
> Signed-off-by: Javier Viguera <javier.viguera@digi.com>
> ---
>
> Probably also worth to be cherry-picked to 'danny' branch.
>
>   meta/recipes-core/base-files/base-files_3.0.14.bb | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/base-files/base-files_3.0.14.bb b/meta/recipes-core/base-files/base-files_3.0.14.bb
> index 6a3db50..e7a9d82 100644
> --- a/meta/recipes-core/base-files/base-files_3.0.14.bb
> +++ b/meta/recipes-core/base-files/base-files_3.0.14.bb
> @@ -129,7 +129,7 @@ do_install_basefilesissue () {
>   			printf "${DISTRO_VERSION} " >> ${D}${sysconfdir}/issue
>   			printf "${DISTRO_VERSION} " >> ${D}${sysconfdir}/issue.net
>   		fi
> -		echo "\n \l" >> ${D}${sysconfdir}/issue
> +		printf "\\\n \\\l\n" >> ${D}${sysconfdir}/issue
>   		echo >> ${D}${sysconfdir}/issue
>   		echo "%h"    >> ${D}${sysconfdir}/issue.net
>   		echo >> ${D}${sysconfdir}/issue.net
>