From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com ([134.134.136.24]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1UASfq-00047K-DX for openembedded-core@lists.openembedded.org; Tue, 26 Feb 2013 23:07:08 +0100 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 26 Feb 2013 13:49:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.84,743,1355126400"; d="scan'208";a="290886190" Received: from envy.jf.intel.com (HELO envy.home) ([10.7.199.55]) by orsmga002.jf.intel.com with ESMTP; 26 Feb 2013 13:50:37 -0800 Message-ID: <512D2E2E.20503@linux.intel.com> Date: Tue, 26 Feb 2013 13:50:38 -0800 From: Darren Hart User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Trevor Woerner References: In-Reply-To: X-Enigmail-Version: 1.5 Cc: Patches and discussions about the oe-core layer Subject: Re: [PATCH 5/7] mkdebugfs.sh: several fixes X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Feb 2013 22:07:20 -0000 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On 02/26/2013 09:43 AM, Trevor Woerner wrote: > On Tue, Feb 26, 2013 at 4:24 AM, Robert Yang wrote: >> Fix mkdebugfs.sh: >> >> *) >> echo "Unknown file $FILE" 1>&2 >> ;; >> esac > > I know this doesn't come from your work, but since you're making > changes, I think it would make for a better error message if the above > said something along the lines of: > > echo "Unknown/unhandled file type '$(stat -c "%F" $FILE)' file:$FILE" > That's fine. Also, there is no need to send my script first and then patch it. It was a 5 minute hack, so just modify and include as a single patch. -- Darren Hart Intel Open Source Technology Center Yocto Project - Technical Lead - Linux Kernel