Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Martin Donnelly <martin.donnelly@ge.com>
To: Saul Wold <sgw@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/2] shadow: remove grpconv argc check
Date: Thu, 28 Feb 2013 15:18:00 +0000	[thread overview]
Message-ID: <512F7528.3050605@ge.com> (raw)
In-Reply-To: <512EE090.3070304@linux.intel.com>

On 28/02/2013 04:44, Saul Wold wrote:
> On 02/27/2013 04:58 AM, Martin Donnelly wrote:
>> The patched version of grpconv takes arguments but the check on
>> argc was not removed. This patch removes this check which
>> otherwise results in a spurious warning during rootfs creation.
>>
>> Signed-off-by: Martin Donnelly <martin.donnelly@ge.com>
>> ---
>>   .../shadow/files/add_root_cmd_options.patch        |   12 +++++++++++-
>>   1 files changed, 11 insertions(+), 1 deletions(-)
>>
>> diff --git
>> a/meta/recipes-extended/shadow/files/add_root_cmd_options.patch
>> b/meta/recipes-extended/shadow/files/add_root_cmd_options.patch
>> index 5edd3b8..ab87e35 100644
>> --- a/meta/recipes-extended/shadow/files/add_root_cmd_options.patch
>> +++ b/meta/recipes-extended/shadow/files/add_root_cmd_options.patch
>
> This patch needs a header also with Upstream-Status: Signed-off-by: and
> a brief explaination (if needed).
>

The existing patch already has the header and Upstream-Status in it, my 
patch to it simply makes the behaviour of the modified pwconv and 
grpconv in shadow-native consistent. I'll resend this patch with the 
Signed-off-by added to the header if you still want that?

Thanks

Martin



      reply	other threads:[~2013-02-28 15:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-27 12:58 [PATCH 1/2] shadow: add build dependency on shadow-native Martin Donnelly
2013-02-27 12:58 ` [PATCH 2/2] shadow: remove grpconv argc check Martin Donnelly
2013-02-28  4:44   ` Saul Wold
2013-02-28 15:18     ` Martin Donnelly [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=512F7528.3050605@ge.com \
    --to=martin.donnelly@ge.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=sgw@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox