From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail1.windriver.com ([147.11.146.13]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1UKWOy-0004jL-Hb for openembedded-core@lists.openembedded.org; Tue, 26 Mar 2013 17:07:10 +0100 Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail1.windriver.com (8.14.5/8.14.3) with ESMTP id r2QFnvE7007265 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Tue, 26 Mar 2013 08:49:57 -0700 (PDT) Received: from [128.224.146.67] (128.224.146.67) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.2.342.3; Tue, 26 Mar 2013 08:49:57 -0700 Message-ID: <5151C3A2.4070806@windriver.com> Date: Tue, 26 Mar 2013 11:49:54 -0400 From: Bruce Ashfield User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 To: Darren Hart References: <5151C361.7020202@linux.intel.com> In-Reply-To: <5151C361.7020202@linux.intel.com> Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH 1/7] linux-yocto/3.8: allow kernel feature _appends to be overriden X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Mar 2013 16:07:10 -0000 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit On 13-03-26 11:48 AM, Darren Hart wrote: > On 03/26/2013 07:46 AM, Bruce Ashfield wrote: >> It was pointed out that the current way the KERNEL_FEATURES variable >> is appended in the base linux-yocto recipe doesn't allow the appended >> features to be prevented in a layer without using python code and >> a recipe finalize hook. >> >> To allow easier overriding of 'extra' or 'optional' features that are >> defined in the linux-yocto recipe, we create a KERNEL_EXTRA_FEATURES >> variable. This variable can be set in a layer to define extra features >> or cleared to prevent the recipe's extra features from being appended >> to the core functionality. > > You know what I'm going to say right? Docume.... right, good. > > Bruce, are you keeping a list of things that have changed and need > documentation in the kernel-dev manual? Could you share it? I do have a list, I'll put it in bugzilla. Bruce > > -- > Darren > >> >> Signed-off-by: Bruce Ashfield >> --- >> meta/recipes-kernel/linux/linux-yocto_3.8.bb | 7 +++---- >> 1 file changed, 3 insertions(+), 4 deletions(-) >> >> diff --git a/meta/recipes-kernel/linux/linux-yocto_3.8.bb b/meta/recipes-kernel/linux/linux-yocto_3.8.bb >> index b395e45..f29675a 100644 >> --- a/meta/recipes-kernel/linux/linux-yocto_3.8.bb >> +++ b/meta/recipes-kernel/linux/linux-yocto_3.8.bb >> @@ -23,8 +23,7 @@ KMETA = "meta" >> COMPATIBLE_MACHINE = "qemuarm|qemux86|qemuppc|qemumips|qemux86-64" >> >> # Functionality flags >> -KERNEL_FEATURES_append = " features/netfilter/netfilter.scc" >> -KERNEL_FEATURES_append_qemux86=" cfg/sound.scc" >> -KERNEL_FEATURES_append_qemux86-64=" cfg/sound.scc" >> -KERNEL_FEATURES_append_qemux86=" cfg/paravirt_kvm.scc" >> +KERNEL_EXTRA_FEATURES ?= "features/netfilter/netfilter.scc" >> +KERNEL_FEATURES_append_qemux86=" ${KERNEL_EXTRA_FEATURES} cfg/sound.scc cfg/paravirt_kvm.scc" >> +KERNEL_FEATURES_append_qemux86-64=" ${KERNEL_EXTRA_FEATURES} cfg/sound.scc" >> KERNEL_FEATURES_append = " ${@bb.utils.contains("TUNE_FEATURES", "mx32", " cfg/x32.scc", "" ,d)}" >> >