From: Kang Kai <Kai.Kang@windriver.com>
To: Saul Wold <sgw@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] opkg: create run-scripts file conditionally
Date: Wed, 3 Apr 2013 09:50:04 +0800 [thread overview]
Message-ID: <515B8ACC.4060303@windriver.com> (raw)
In-Reply-To: <515B4774.6000200@linux.intel.com>
On 2013年04月03日 05:02, Saul Wold wrote:
> On 03/25/2013 11:43 PM, Kang Kai wrote:
>> This bug occurs on rpm-based sdk image.
>>
>> update-alternatives-cworth is default installed into sato image. And for
>> sato-sdk image, it installs every related dev packages.
>> update-alternatives-cworth is from opkg, so opkg-dev is installed and it
>> requires opkg, then opkg is installed into sato-sdk image.
>>
>> This causes the script file run-postinsts installed by rpm will be
>> overwrited by opkg on rpm-based sdk image.
>>
>> Judge the image package type and don't create run-scripts file when
>> package type is not ipk.
>>
>> [YOCTO #3223]
>>
>> Signed-off-by: Kang Kai <kai.kang@windriver.com>
>> ---
>> meta/recipes-devtools/opkg/opkg.inc | 6 ++++++
>> 1 files changed, 6 insertions(+), 0 deletions(-)
>>
>> diff --git a/meta/recipes-devtools/opkg/opkg.inc
>> b/meta/recipes-devtools/opkg/opkg.inc
>> index f9c1202..bc80cb0 100644
>> --- a/meta/recipes-devtools/opkg/opkg.inc
>> +++ b/meta/recipes-devtools/opkg/opkg.inc
>> @@ -59,10 +59,16 @@ do_install_append_class-native() {
>>
>> POSTLOG ?= "/var/log/postinstall.log"
>> REDIRECT_CMD = "${@base_contains('IMAGE_FEATURES', 'debug-tweaks',
>> '>${POSTLOG} 2>&1', '', d)}"
>> +PKGTYPE = "${@d.getVar('IMAGE_PKGTYPE', True)}"
>>
>> pkg_postinst_${PN} () {
>> #!/bin/sh
>> if [ "x$D" != "x" ]; then
>> + # if installed to a rpm/deb based image, don't create run-postinsts
>> file
>> + if [ "x${PKGTYPE}" != "xipk" ]; then
>> + exit 0
>> + fi
>> +
> I understand what you are trying to do here, I think Richard was
> questioning if this is the right implementation of the change. I think
> if you look at how RPM does it and then make the *run-postinsts script
> an update-alternatives so each package system does it consistently,
> this will also require a change to dpkg.
>
> Then there might have to be some setting of the PRIORITY for when each
> package system is installed.
Thanks. I'll re-implement it.
Regards,
Kai
>
> Sau!
>
>> install -d $D${sysconfdir}/rcS.d
>> # this happens at S98 where our good 'ole packages script used to run
>> echo "#!/bin/sh
>>
>
next prev parent reply other threads:[~2013-04-03 2:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 6:43 [PATCH 0/1] V2: Create postinstall script for opkg conditionally Kang Kai
2013-03-26 6:43 ` [PATCH 1/1] opkg: create run-scripts file conditionally Kang Kai
2013-04-02 21:02 ` Saul Wold
2013-04-03 1:50 ` Kang Kai [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-03-25 7:22 [PATCH 0/1] Create postinstall script for opkg conditionally Kang Kai
2013-03-25 7:22 ` [PATCH 1/1] opkg: create run-scripts file conditionally Kang Kai
2013-03-25 14:32 ` Richard Purdie
2013-03-26 2:16 ` Kang Kai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515B8ACC.4060303@windriver.com \
--to=kai.kang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=sgw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox