From: Mark Hatle <mark.hatle@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] bluez4: add readline dependency
Date: Mon, 8 Apr 2013 13:19:05 -0500 [thread overview]
Message-ID: <51630A19.5090305@windriver.com> (raw)
In-Reply-To: <51630510.7080105@linux.intel.com>
On 4/8/13 12:57 PM, Saul Wold wrote:
> On 04/08/2013 05:56 AM, Alex DAMIAN wrote:
>> From: Alexandru DAMIAN <alexandru.damian@intel.com>
>>
>> bluez4 uses readline to be build, but the dependency is not listed
>> This is listed in the configuration log.
>> So we add it.
>>
> As far as I can tell it's needed only for gatttool, is this a tool that
> we need / want to provide for bluez?
>
> This seems to be a tools for viewing the Generic Attribute Profile (GATT).
>
> It can be disabled by setting "ac_cv_lib_readline_main=no"
We -really- want to avoid readline if possible, as it brings in GPLv3
dependencies into the system.
If that tool is generically useful, I'd suggest a PACKAGECONFIG setting then.
--Mark
>
> Sau!
>
>
>> Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
>> ---
>> meta/recipes-connectivity/bluez/bluez4.inc | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-connectivity/bluez/bluez4.inc b/meta/recipes-connectivity/bluez/bluez4.inc
>> index bff24d3..42d82b0 100644
>> --- a/meta/recipes-connectivity/bluez/bluez4.inc
>> +++ b/meta/recipes-connectivity/bluez/bluez4.inc
>> @@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \
>> file://COPYING.LIB;md5=fb504b67c50331fc78734fed90fb0e09 \
>> file://src/main.c;beginline=1;endline=24;md5=9bc54b93cd7e17bf03f52513f39f926e \
>> file://sbc/sbc.c;beginline=1;endline=25;md5=1a40781ed30d50d8639323a184aeb191"
>> -DEPENDS = "udev libusb dbus-glib glib-2.0 libcheck"
>> +DEPENDS = "udev libusb dbus-glib glib-2.0 libcheck readline"
>> RDEPENDS_${PN}-dev = "bluez-hcidump"
>>
>> PACKAGECONFIG ??= "\
>>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
next prev parent reply other threads:[~2013-04-08 18:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 12:56 [PATCH] bluez4: add readline dependency Alex DAMIAN
2013-04-08 17:57 ` Saul Wold
2013-04-08 18:19 ` Mark Hatle [this message]
2013-04-09 14:52 ` Damian, Alexandru
2013-04-09 14:58 ` Iorga, Cristian
2013-04-09 15:04 ` Burton, Ross
2013-04-09 15:11 ` Saul Wold
2013-04-22 17:15 ` Javier Viguera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51630A19.5090305@windriver.com \
--to=mark.hatle@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox