Re: [PATCH 1/1] xcursor-transparent-theme: install index.theme explicitly

[wenzong fan <wenzong.fan@windriver.com>]

On 04/10/2013 05:17 PM, Burton, Ross wrote:
> On 10 April 2013 09:00, Martin Jansa <martin.jansa@gmail.com> wrote:
>> On Wed, Apr 10, 2013 at 11:26:35AM +0800, wenzong.fan@windriver.com wrote:
>>> The xcursor-transparent-theme doesn't install index.theme by default,
>>> this might cause below command fails on target:
>>>
>>>      $ gtk-update-icon-cache -q /usr/share/icons/xcursor-transparent
>>>      Error: "gtk-update-icon-cache: No theme index file"
>>>
>>> Just install index.theme explicitly to remove those error, its content
>>> is from xcursor-transparent-theme's README file.
>>
>> Wasn't this discussed and fixed before? IIRC the conclusion was that
>> postinst should check if there is index.theme or ignore it missing, not
>> adding index.theme.
>
> NACK.
>
> Martin is right, the gtk-icon-cache class uses -t when updating the caches:
>
>         --ignore-theme-index, -t
>             Don't check for the existence of 'index.theme' in the icon theme
>             directory. Without this option, gtk-update-icon-cache refuses to
>             create an icon cache in a directory which does not appear to be the
>             toplevel directory of an icon theme.
>
> If someone is not using gtk-icon-cache.bbclass they either should, or
> have a good reason and also use -t.

Oh, I did think I missed something about the discussion of index.theme & 
gtk-update-icon-cache. I recall this patch and sorry for the noise.

I appreciate your clarifications!

Thanks
Wenzong

>
> Ross
>