From: Saul Wold <sgw@linux.intel.com>
To: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/2] udev-extraconf: Add -o silent to auto mount for mount.util-linux
Date: Sat, 13 Apr 2013 09:55:46 -0700 [thread overview]
Message-ID: <51698E12.9070103@linux.intel.com> (raw)
In-Reply-To: <13e0390dbb6.2760.0f39ed3bcad52ef2c88c90062b7714dc@gmail.com>
On 04/13/2013 06:23 AM, Bernhard Reutner-Fischer wrote:
> On 13 April 2013 12:26:38 Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
>> On Sat, 2013-04-13 at 00:28 -0700, Saul Wold wrote:
>> > This will silence some of the noisy output from mount.util-linux and
>> the kernel
>> > when trying to automount filesystems or devices. Busybox does not
>> accept the silent
>> > option, it uses a "loud" option instead.
>> > [YOCTO #3935]
>> > Signed-off-by: Saul Wold <sgw@linux.intel.com>
>> > ---
>> > meta/recipes-core/udev/udev-extraconf/mount.sh | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> As far as I can see this will break with busybox mount. Is there a 2/2
>> missing?
>
> IIRC Busybox defaults to be silent (right?), I will thus add (and
> ignore) silent. I will have a look in the evening.
>
Dangit, I sent the wrong patch, I have the correct one, will resend.
Sau!
> Thanks for the heads up!
> Cheers,
>>
>> > diff --git a/meta/recipes-core/udev/udev-extraconf/mount.sh
>> b/meta/recipes-core/udev/udev-extraconf/mount.sh
>> > index 99c76b2..7b58361 100644
>> > --- a/meta/recipes-core/udev/udev-extraconf/mount.sh
>> > +++ b/meta/recipes-core/udev/udev-extraconf/mount.sh
>> > @@ -22,7 +22,7 @@ automount() {
>> > ! test -d "/media/$name" && mkdir -p "/media/$name"
>> >
>> > - if ! $MOUNT -t auto $DEVNAME "/media/$name"
>> > + if ! $MOUNT -o silent -t auto $DEVNAME "/media/$name"
>> > then
>> > #logger "mount.sh/automount" "$MOUNT -t auto $DEVNAME
>> \"/media/$name\" failed!"
>> > rm_dir "/media/$name"
>>
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>
> Sent with AquaMail for Android
> http://www.aqua-mail.com
>
>
>
>
prev parent reply other threads:[~2013-04-13 17:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-13 7:28 [PATCH 1/2] udev-extraconf: Add -o silent to auto mount for mount.util-linux Saul Wold
2013-04-13 10:26 ` Richard Purdie
2013-04-13 13:23 ` Bernhard Reutner-Fischer
2013-04-13 16:55 ` Saul Wold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51698E12.9070103@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=rep.dot.nop@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox