Re: [OE-core] [PATCH 1/2] oeqa/manual/bsp-hw.json : removal of click_terminal_icon_on_X_desktop manual test because of automated

["Richard Purdie" <richard.purdie@linuxfoundation.org>]

On Wed, 2020-10-28 at 11:40 +0800, jay.shen.teoh@intel.com wrote:
> From: Teoh Jay Shen <jay.shen.teoh@intel.com>
> 
> removing click_terminal_icon_on_X_desktop manual test as this function is now tested by terminal.py automated runtime test
> 
> Signed-off-by: Teoh Jay Shen <jay.shen.teoh@intel.com>
> ---
>  meta/lib/oeqa/manual/bsp-hw.json | 22 ----------------------
>  1 file changed, 22 deletions(-)
> 
> diff --git a/meta/lib/oeqa/manual/bsp-hw.json b/meta/lib/oeqa/manual/bsp-hw.json
> index 75b8975..790c0c0 100644
> --- a/meta/lib/oeqa/manual/bsp-hw.json
> +++ b/meta/lib/oeqa/manual/bsp-hw.json
> @@ -365,28 +365,6 @@
>      },
>      {
>          "test": {
> -            "@alias": "bsps-hw.bsps-hw.click_terminal_icon_on_X_desktop",
> -            "author": [
> -                {
> -                    "email": "alexandru.c.georgescu@intel.com",
> -                    "name": "alexandru.c.georgescu@intel.com"
> -                }
> -            ],
> -            "execution": {
> -                "1": {
> -                    "action": "After system launch and X start up, click terminal icon on desktop",
> -                    "expected_results": ""
> -                },
> -                "2": {
> -                    "action": "Check if only one terminal window launched and no other problem met",
> -                    "expected_results": "There should be no problem after launching terminal . "
> -                }
> -            },
> -            "summary": "click_terminal_icon_on_X_desktop"
> -        }
> -    },
> -    {
> -        "test": {

I'm afraid this testcase does not match what terminal.py is testing.
The test here is to:

a) check it launches
b) check there is only one terminal

and the test in terminal.py does neither of these things.

Cheers,

Richard