From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com ([134.134.136.20]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1UXeMB-0000Z6-3q for openembedded-core@lists.openembedded.org; Wed, 01 May 2013 23:14:49 +0200 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 01 May 2013 13:56:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,591,1363158000"; d="scan'208";a="306403471" Received: from envy2.jf.intel.com (HELO envy2.home) ([10.7.199.54]) by orsmga001.jf.intel.com with ESMTP; 01 May 2013 13:56:37 -0700 Message-ID: <51818184.4000301@linux.intel.com> Date: Wed, 01 May 2013 13:56:36 -0700 From: Darren Hart User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Tomas Frydrych References: <1366991439-14728-1-git-send-email-tf+lists.yocto@r-finger.com> <1367052737-8519-1-git-send-email-tf+lists.yocto@r-finger.com> <51817A25.6050009@linux.intel.com> <5181806C.4070708@r-finger.com> In-Reply-To: <5181806C.4070708@r-finger.com> X-Enigmail-Version: 1.5.1 Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH] ia32-base.inc: remove inapropriate grub dependency X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 May 2013 21:14:50 -0000 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On 05/01/2013 01:51 PM, Tomas Frydrych wrote: > On 01/05/13 21:25, Darren Hart wrote: >> >> >> On 04/27/2013 01:52 AM, tf+lists.yocto@r-finger.com wrote: >>> From: Tomas Frydrych >>> >>> There is no good reason for ia32 machines to have hard dependency on grub, >>> as there are other bootloaders available for ia32 platforms. >>> >>> Signed-off-by: Tomas Frydrych >>> --- >>> meta/conf/machine/include/ia32-base.inc | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/meta/conf/machine/include/ia32-base.inc b/meta/conf/machine/include/ia32-base.inc >>> index 921c740..cb542a5 100644 >>> --- a/meta/conf/machine/include/ia32-base.inc >>> +++ b/meta/conf/machine/include/ia32-base.inc >>> @@ -9,7 +9,6 @@ MACHINE_FEATURES += "screen keyboard pci usbhost ext2 ext3 x86 \ >>> acpi serial usbgadget alsa" >>> >>> MACHINE_EXTRA_RRECOMMENDS += "kernel-modules eee-acpi-scripts" >>> -MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "grub" >> >> Agreed - but do the images still build as currently written after you >> remove it here? > > I have not tested the efi path, though I think the grub-efi.bbclass > takes care of the grub dependency. In the non-efi case the grub > dependency is taken care of by initramfs-live-install.bb. grub-efi is properly managed via the bootimg.bbclass and MACHINE_FEATURES ~= efi. Acked-by: Darren Hart Thanks Tomas! -- Darren Hart Intel Open Source Technology Center Yocto Project - Technical Lead - Linux Kernel