Re: [PATCH v6] syslinux: Update to 4.06

[Jonathan Liu <net147@gmail.com>]

On 7/05/2013 7:05 AM, Saul Wold wrote:
>
>
> On 05/06/2013 05:31 AM, Jonathan Liu wrote:
>> Patches are now part of upstream or no longer needed.
>> Added new util-linux dependency for isohybrid.
>> Paths updated to reflect directory structure changes.
>>
>> INCDIR isn't used by the build process during compilation which results
>> in the compiler not finding uuid/uuid.h from util-linux when compiling
>> isohybrid unless it exists on the host system. This was fixed by adding
>> -isystem ${STAGING_INCDIR} to CC when calling make.
>>
>
> I am not sure what's changing in all these version since you have not 
> added a changelog.  This version still has trouble with building 
> isohybrid.
>
> I am not sure what you are doing to test this, but I would like to see 
> a more information about how you are building and testing this before 
> I take another version and find it will fail.
>
> I appreciate the work it takes to update a recipe, but we need to get 
> it correct and tested
v1 - Patch malformed by email client
v2 - Added util-linux-native dependency.
Resent patch directly using git send-email
isohybrid.c:39:23: fatal error: uuid/uuid.h: No such file or directory
v3 - Changed util-linux-native dependency to util-linux so ot will work 
when building for target as well.
Recipe finds uuid/uuid.h but from my syslinux installed on my host so it 
appeared everything compiled fine but it didn't.
v4 - Added -I${includedir} to CC when calling make.
This didn't work because includedir is /usr/include when it should point 
to the /usr/include in the sysroot.
v5 - Changed -I${includedir} to -isystem ${includedir}.
Still didn't work because includedir is /usr/include when it should 
point to the /usr/include in the sysroot.
I was changed to -isystem after reading GCC manual. I figured it was 
better for it to search its local source files first because checking 
system include directories like /usr/include.
v6 - Changed -isystem ${includedir} to -isystem ${STAGING_INCDIR}.

Testing:
I am using a custom image based on atom-pc core-image-minimal, with 
.hddimage output.
Tested changes using "bitbake -c cleansstate syslinux syslinux-native; 
bitbake syslinux syslinux-native".
For testing v6, did a clean rebuild of everything, renamed 
/usr/include/uuid.h to /usr/include/uuid.h.bak on my host system and 
tests it:
1. Fails without the patch - ok
2. Succeeds with the patch - ok

Regards,
Jonathan