Re: [PATCH] eglibc: include libgcc when libpthread is enabled

[Mark Hatle <mark.hatle@windriver.com>]

On 5/9/13 9:32 AM, Khem Raj wrote:
>
> On May 9, 2013, at 5:55 AM, Bogdan Marinescu <bogdan.a.marinescu@intel.com> wrote:
>
>> libpthread needs libgcc to function properly. Without libgcc I get
>> the following error:
>>
>> root@qemux86:~# tclsh
>> % exit 0
>> libgcc_s.so.1 must be installed for pthread_cancel to work
>> Aborted
>> root@qemux86:~#
>>
>> This patch fixes the above issue and similar ones by adding a
>> runtime dependency of libgcc to eglibc when threads are enabled.
>>
>> Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com>
>> ---
>> meta/recipes-core/eglibc/eglibc.inc |    2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-core/eglibc/eglibc.inc b/meta/recipes-core/eglibc/eglibc.inc
>> index 1e04197..24fb05b 100644
>> --- a/meta/recipes-core/eglibc/eglibc.inc
>> +++ b/meta/recipes-core/eglibc/eglibc.inc
>> @@ -35,7 +35,7 @@ siteconfig_do_siteconfig_gencache_prepend = " \
>> # nptl needs unwind support in gcc, which can't be built without glibc.
>> DEPENDS = "virtual/${TARGET_PREFIX}gcc-initial linux-libc-headers virtual/${TARGET_PREFIX}libc-initial"
>> # nptl needs libgcc but dlopens it, so our shlibs code doesn't detect this
>> -#RDEPENDS_${PN} += "${@['','libgcc']['nptl' in '${GLIBC_ADDONS}']}"
>> +RDEPENDS_${PN} += "${@['','libgcc']['nptl' in '${GLIBC_ADDONS}']}"
>
> ah too early. I think you should spin out libpthread into separate package and then RDEPEND_libpthread = "…"
> and don't use nptl we do not have any other option now a days.

This would be my suggestion.  I'd also want to make sure there is a 
libpthread-dev (which for some reason I think there already is) because the 
links in there are required for on-target thread debugging...

--Mark

>
>> PROVIDES = "virtual/libc virtual/${TARGET_PREFIX}libc-for-gcc"
>> PROVIDES += "virtual/libintl virtual/libiconv"
>> inherit autotools
>> --
>> 1.7.10.4
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>