Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Joe Slater <jslater@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH [v1] 1/1] zlib: put shared libraries in base_libdir
Date: Thu, 16 May 2013 10:28:19 +0300	[thread overview]
Message-ID: <51948A93.8060705@linux.intel.com> (raw)
In-Reply-To: <1368652657-3841-1-git-send-email-jslater@windriver.com>

On 05/16/2013 12:17 AM, Joe Slater wrote:
> We put the shared libraries in base_libdir because at least
> one library under base_libdir, pam_cracklib.so, needs them
> and will cause a qa warning when it is built.

missing a Signed-off-by: and the [v1] seems to cause the subject to
get parsed wrong.

Sau!

> ---
>   meta/recipes-core/zlib/zlib_1.2.7.bb |   15 +++++++++++++++
>   1 files changed, 15 insertions(+), 0 deletions(-)
>
> diff --git a/meta/recipes-core/zlib/zlib_1.2.7.bb b/meta/recipes-core/zlib/zlib_1.2.7.bb
> index 803fec3..dfdf5fe 100644
> --- a/meta/recipes-core/zlib/zlib_1.2.7.bb
> +++ b/meta/recipes-core/zlib/zlib_1.2.7.bb
> @@ -6,6 +6,8 @@ SECTION = "libs"
>   LICENSE = "Zlib"
>   LIC_FILES_CHKSUM = "file://zlib.h;beginline=4;endline=23;md5=94d1b5a40dadd127f3351471727e66a9"
>
> +PR = "r1"
> +
>   SRC_URI = "http://www.zlib.net/${BPN}-${PV}.tar.bz2 \
>              file://remove.ldconfig.call.patch \
>              "
> @@ -24,4 +26,17 @@ do_install() {
>   	oe_runmake DESTDIR=${D} install
>   }
>
> +# We move zlib shared libraries for target builds to avoid
> +# qa warnings.
> +#
> +do_install_append_class-target() {
> +	if [ ${base_libdir} != ${libdir} ]
> +	then
> +		mkdir -p ${D}/${base_libdir}
> +		mv ${D}/${libdir}/libz.so.* ${D}/${base_libdir}
> +		tmp=`readlink ${D}/${libdir}/libz.so`
> +		ln -sf ../../${base_libdir}/$tmp ${D}/${libdir}/libz.so
> +	fi
> +}
> +
>   BBCLASSEXTEND = "native nativesdk"
>



      reply	other threads:[~2013-05-16  7:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-15 21:17 [PATCH [v1] 1/1] zlib: put shared libraries in base_libdir Joe Slater
2013-05-16  7:28 ` Saul Wold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51948A93.8060705@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=jslater@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox