From: Saul Wold <sgw@linux.intel.com>
To: "Eric Bénard" <eric@eukrea.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v2 2/2] gtk-icon-cache pixbufcache: add a clear dependency on gdk-pixbuf-native
Date: Fri, 31 May 2013 15:35:35 +0900 [thread overview]
Message-ID: <51A844B7.9020201@linux.intel.com> (raw)
In-Reply-To: <1369946430-12959-2-git-send-email-eric@eukrea.com>
On 05/31/2013 05:40 AM, Eric Bénard wrote:
> not really sure if the dependency is always inherited but at least
> there won't be bad surprise.
>
This seems to have caused a circular dependency, not sure the exact
nature, please verify this.
There might have been a patch from someone else recently, so please
check the latest master.
Thanks
Sau!
> Signed-off-by: Eric Bénard <eric@eukrea.com>
> ---
> meta/classes/gtk-icon-cache.bbclass | 2 +-
> meta/classes/pixbufcache.bbclass | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/gtk-icon-cache.bbclass b/meta/classes/gtk-icon-cache.bbclass
> index 789fa38..8ed7feb 100644
> --- a/meta/classes/gtk-icon-cache.bbclass
> +++ b/meta/classes/gtk-icon-cache.bbclass
> @@ -1,6 +1,6 @@
> FILES_${PN} += "${datadir}/icons/hicolor"
>
> -DEPENDS += "${@['hicolor-icon-theme', '']['${BPN}' == 'hicolor-icon-theme']} gtk-update-icon-cache-native"
> +DEPENDS += "${@['hicolor-icon-theme', '']['${BPN}' == 'hicolor-icon-theme']} gtk-update-icon-cache-native gdk-pixbuf-native"
>
> gtk_icon_cache_postinst() {
> if [ "x$D" != "x" ]; then
> diff --git a/meta/classes/pixbufcache.bbclass b/meta/classes/pixbufcache.bbclass
> index 274d67d..4ac17ee 100644
> --- a/meta/classes/pixbufcache.bbclass
> +++ b/meta/classes/pixbufcache.bbclass
> @@ -3,7 +3,7 @@
> # packages.
> #
>
> -DEPENDS += "qemu-native"
> +DEPENDS += "qemu-native gdk-pixbuf-native"
> inherit qemu
>
> PIXBUF_PACKAGES ??= "${PN}"
>
next prev parent reply other threads:[~2013-05-31 6:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 20:40 [PATCH v2 1/2] hicolor-icon-theme: keep inherited dependencies and switch to gnomebase Eric Bénard
2013-05-30 20:40 ` [PATCH v2 2/2] gtk-icon-cache pixbufcache: add a clear dependency on gdk-pixbuf-native Eric Bénard
2013-05-31 6:35 ` Saul Wold [this message]
2013-05-31 6:55 ` Eric Bénard
2013-05-31 11:50 ` [PATCH v2 1/2] hicolor-icon-theme: keep inherited dependencies and switch to gnomebase Burton, Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A844B7.9020201@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=eric@eukrea.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox