From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f178.google.com (mail-pd0-f178.google.com [209.85.192.178]) by mail.openembedded.org (Postfix) with ESMTP id D0F5B6163F for ; Fri, 31 May 2013 10:35:59 +0000 (UTC) Received: by mail-pd0-f178.google.com with SMTP id w11so1958656pde.23 for ; Fri, 31 May 2013 03:36:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=hGMQzQbXPgl/mWfNxL6mxDxSxklY6diu5Y6DBDiEIHQ=; b=Fmun7B5Q94gMq4rPMHCPWLMkFmiCtiQ3mfabBPDi6ixXZq0MxVWK5aKqCZ4Fc2aZLI 9cLAfqUP2hSo0aOzvw3w7aU49C0bqFdHIH1CwSl1FVFDgZ8NLIDD5nuWmkoGRXl8uUsU /hDBQ0Xpe3P/ImB72CWVz8h8D5ogZrJhPg4JzKTrOQ0LonSn3xT/JppB8odH/YKrU7SF yAngmM9rUPmkh064a0O88OmdfOoHr0GRapmwCvzed80NxLMPj9opkx0ie6EpUELc7hFs YNrZ0nvGkJ2nsTup+5f0vUIKAA/eIqEk25CGoruducTkWvXysIe17W3bFmsCFRQ0BNbz yZ0A== X-Received: by 10.66.163.5 with SMTP id ye5mr12777551pab.60.1369996561260; Fri, 31 May 2013 03:36:01 -0700 (PDT) Received: from [192.168.0.2] (60-242-179-244.static.tpgi.com.au. [60.242.179.244]) by mx.google.com with ESMTPSA id ya4sm46150840pbb.24.2013.05.31.03.35.59 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 31 May 2013 03:36:00 -0700 (PDT) Message-ID: <51A87BED.5020908@gmail.com> Date: Fri, 31 May 2013 20:31:09 +1000 From: Jonathan Liu User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Jonathan Liu References: <1369993335-21441-1-git-send-email-net147@gmail.com> <51A87B7F.7050702@gmail.com> In-Reply-To: <51A87B7F.7050702@gmail.com> Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH] buildhistory: record removals with Git 2.0 and later X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 May 2013 10:35:59 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 31/05/2013 8:29 PM, Jonathan Liu wrote: > On 31/05/2013 7:42 PM, Jonathan Liu wrote: >> There is a behavior change with Git 2.0 where "git add ." will no >> longer record removals by default unless -A (--all) is specified. >> Change to "git add -A ." so removals are recorded with Git 2.0 and >> later. >> >> Signed-off-by: Jonathan Liu >> --- >> meta/classes/buildhistory.bbclass | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > Hmm... looks like I interpreted the Git warning incorrectly. Maybe I > need to look into this a bit more and perhaps change the commit message. > > The following appears after a build with buildhistory enabled: > warning: You ran 'git add' with neither '-A (--all)' or > '--ignore-removal', > whose behaviour will change in Git 2.0 with respect to paths you removed. > Paths like 'test.txt' that are > removed from your working tree are ignored with this version of Git. > > * 'git add --ignore-removal ', which is the current default, > ignores paths you removed from your working tree. > > * 'git add --all ' will let you also record the removals. > > Run 'git status' to check the paths you removed from your working tree. > > Regards, > Jonathan The warning appears in Git 1.8.3. The path removed was the package information for a kernel module after updating from 3.8.11 to 3.8.13. Regards, Jonathan