From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mail.openembedded.org (Postfix) with ESMTP id 88CD36A598 for ; Wed, 5 Jun 2013 17:01:08 +0000 (UTC) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 05 Jun 2013 09:58:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,808,1363158000"; d="scan'208";a="324748137" Received: from unknown (HELO [10.255.13.19]) ([10.255.13.19]) by orsmga001.jf.intel.com with ESMTP; 05 Jun 2013 10:01:09 -0700 Message-ID: <51AF6ED5.4010500@linux.intel.com> Date: Wed, 05 Jun 2013 10:01:09 -0700 From: Saul Wold User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Paul Eggleton References: <1370422910-24366-1-git-send-email-net147@gmail.com> <20130605093056.GD30727@jama> <51AF6B79.3040506@linux.intel.com> <2054363.UxqkIOrzAJ@helios> In-Reply-To: <2054363.UxqkIOrzAJ@helios> Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH] qmake2.bbclass: export OE_QMAKE_QT_CONFIG X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Jun 2013 17:01:08 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 06/05/2013 09:57 AM, Paul Eggleton wrote: > On Wednesday 05 June 2013 09:46:49 Saul Wold wrote: >> On 06/05/2013 02:30 AM, Martin Jansa wrote: >>> On Wed, Jun 05, 2013 at 07:01:50PM +1000, Jonathan Liu wrote: >>>> qconfig.pri was not being loaded by qmake properly. This means Qt >>>> qmake projects are unable to query QT_ARCH, QT_VERSION and other >>>> variables defined in qconfig.pri. >>>> >>>> Export OE_QMAKE_QT_CONFIG, setting it to the location of qconfig.pri >>>> so that it can be located by qmake. >>> >>> There is such patch already: >>> http://lists.openembedded.org/pipermail/openembedded-core/2013-May/078314. >>> html >> >> Got lost in my queue, adding it for the next MUT. > > FWIW I am still concerned by the assertion in the commit message about it > causing undesirable behaviour. I'd want that checked out and the note removed > before we look at merging this. > OK, I will shelf this until I hear more about the testing of this change regarding the original patch's note. Sau! > Cheers, > Paul >