From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail1.windriver.com (mail1.windriver.com [147.11.146.13]) by mail.openembedded.org (Postfix) with ESMTP id A7FF56A918 for ; Sat, 8 Jun 2013 02:10:19 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail1.windriver.com (8.14.5/8.14.3) with ESMTP id r582AKrB023182 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Fri, 7 Jun 2013 19:10:20 -0700 (PDT) Received: from [128.224.162.233] (128.224.162.233) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server (TLS) id 14.2.342.3; Fri, 7 Jun 2013 19:10:18 -0700 Message-ID: <51B292AB.6040602@windriver.com> Date: Sat, 8 Jun 2013 10:10:51 +0800 From: ChenQi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Otavio Salvador References: <4caf51c1d2225dc66aeef8326ba0616d97f7c691.1370585547.git.Qi.Chen@windriver.com> In-Reply-To: X-Originating-IP: [128.224.162.233] Cc: qingtao.cao@windriver.com, Patches and discussions about the oe-core layer Subject: Re: [PATCH 1/8] busybox: remove the postinst part of the recipe X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Jun 2013 02:10:19 -0000 Content-Type: multipart/alternative; boundary="------------020502040607080907080500" --------------020502040607080907080500 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit On 06/07/2013 08:32 PM, Otavio Salvador wrote: > > > > On Fri, Jun 7, 2013 at 3:13 AM, > wrote: > > From: Chen Qi > > > Remove the pkg_postinst_${PN} from this recipe, as it's redundant. > It basically wants to do the same thing as the update-alternatives > does. But it doesn't do it well. > > Signed-off-by: Chen Qi > > > > Instead of removing it, please convert it here for update-alternatives > so it keeps working on this commit and allow bisect in future if need. > Hi Otavio, Thanks for your review and comments. Sorry but I don't understand it :( What do you mean by "convert it for update-alternatives"? Could you please give me a little more explanation? Best Regards, Chen Qi > -- > Otavio Salvador O.S. Systems > http://www.ossystems.com.br http://projetos.ossystems.com.br > Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 --------------020502040607080907080500 Content-Type: text/html; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit
On 06/07/2013 08:32 PM, Otavio Salvador wrote:



On Fri, Jun 7, 2013 at 3:13 AM, <Qi.Chen@windriver.com> wrote:
From: Chen Qi <Qi.Chen@windriver.com>

Remove the pkg_postinst_${PN} from this recipe, as it's redundant.
It basically wants to do the same thing as the update-alternatives
does. But it doesn't do it well.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>

Instead of removing it, please convert it here for update-alternatives so it keeps working on this commit and allow bisect in future if need. 

Hi Otavio,

Thanks for your review and comments.
Sorry but I don't understand it :(
What do you mean by "convert it for update-alternatives"?
Could you please give me a little more explanation?

Best Regards,
Chen Qi

--
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

--------------020502040607080907080500--