From: Darren Hart <dvhart@linux.intel.com>
To: Jonathan Liu <net147@gmail.com>
Cc: "openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 2/3] boot-directdisk: Scope HDDDIR and HDDIMG variables to avoid conflicts
Date: Mon, 10 Jun 2013 09:36:15 -0700 [thread overview]
Message-ID: <51B6007F.7020003@linux.intel.com> (raw)
In-Reply-To: <CANwerB0bjquna2deETcig+e_=HTjT0TbEHC-YaA6dDH+3q1z2g@mail.gmail.com>
On 06/09/2013 05:11 AM, Jonathan Liu wrote:
> On 8 June 2013 09:31, Darren Hart <dvhart@linux.intel.com> wrote:
>> On 05/08/2013 08:24 PM, Jonathan Liu wrote:
>>> These variables should not be shared with other image classes.
>>> The bootimg class also has an HDDDIR variable that could be overwritten
>>> if executing concurrently in the same image recipe.
>>
>> Nice catch. Would you considering sending a patch against the bootimg
>> class as well?
>
> I did originally submit a patch against the bootimg class as well but
> it turns out those variables are used by grub-efi.bbclass and
> syslinux.bbclass. See
> http://lists.openembedded.org/pipermail/openembedded-core/2013-May/078011.html.
Ah yes. And boot-directdisk.bbclass also makes use of those. Sounds like
some investigation into how to better modularize this is in order.
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel
next prev parent reply other threads:[~2013-06-10 16:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 3:24 [PATCH v9 1/3] syslinux: Update to 4.06 Jonathan Liu
2013-05-09 3:24 ` [PATCH 2/3] boot-directdisk: Scope HDDDIR and HDDIMG variables to avoid conflicts Jonathan Liu
2013-06-07 23:31 ` Darren Hart
2013-06-09 12:11 ` Jonathan Liu
2013-06-10 16:36 ` Darren Hart [this message]
2013-05-09 3:24 ` [PATCH 3/3] image-vmdk: Fix error recreating symbolic link Jonathan Liu
2013-05-09 8:33 ` Robert Yang
2013-05-09 11:59 ` Jonathan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B6007F.7020003@linux.intel.com \
--to=dvhart@linux.intel.com \
--cc=net147@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox