Re: [PATCH 1/2] strace: update depends

[Kang Kai <Kai.Kang@windriver.com>]

On 2013年06月17日 23:11, Richard Purdie wrote:
> On Sun, 2013-06-16 at 22:16 +0800, Kai Kang wrote:
>> Build strace with libaio and acl to support more features. Because no
>> native libaio package, just add dependencies for target.
>>
>> Signed-off-by: Kai Kang <kai.kang@windriver.com>
>> ---
>>   meta/recipes-devtools/strace/strace_4.7.bb |    2 ++
>>   1 files changed, 2 insertions(+), 0 deletions(-)
> Shouldn't this be implemented like the other packages as PACKAGECONFIG
> options? That is how acl is handled elsewhere at least...

Yes, PACKAGECONFIG is the right way. I'll send V2.

Thanks,
Kai

>
> Cheers,
>
> Richard
>
>> diff --git a/meta/recipes-devtools/strace/strace_4.7.bb b/meta/recipes-devtools/strace/strace_4.7.bb
>> index e360e63..bcc7bd9 100644
>> --- a/meta/recipes-devtools/strace/strace_4.7.bb
>> +++ b/meta/recipes-devtools/strace/strace_4.7.bb
>> @@ -5,6 +5,8 @@ LICENSE = "BSD"
>>   LIC_FILES_CHKSUM = "file://COPYRIGHT;md5=124500c21e856f0912df29295ba104c7"
>>   PR = "r4"
>>   
>> +DEPENDS_class-target += "libaio acl"
>> +
>>   SRC_URI = "${SOURCEFORGE_MIRROR}/strace/strace-${PV}.tar.xz \
>>              file://0003-util-fix-building-when-glibc-has-a-stub-process_vm_r.patch \
>>              file://0014-x32-update-syscall-table.patch \
>
>


-- 
Regards,
Neil | Kai Kang